Skip to content

bpo-41045: Document debug feature of f-strings ('=') #21509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 8 commits into from
Jul 27, 2020
Merged

bpo-41045: Document debug feature of f-strings ('=') #21509

miss-islington merged 8 commits into from
Jul 27, 2020

Conversation

@amaajemyfren
Copy link
Contributor

@amaajemyfren amaajemyfren commented Jul 16, 2020 •
edited by miss-islington
Loading

Co-Authored-By: Rishi [email protected]

https://bugs.python.org/issue41045

Automerge-Triggered-By: @gvanrossum

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 16, 2020
gvanrossum
gvanrossum reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have two small requests.

@gvanrossum gvanrossum changed the title bpo-41045 Proposal to document debug features of f-strings bpo-41045 Document debug feature of f-strings ('=') Jul 23, 2020
@gvanrossum gvanrossum changed the title bpo-41045 Document debug feature of f-strings ('=') bpo-41045: Document debug feature of f-strings ('=') Jul 23, 2020
@gvanrossum
Copy link
Member

gvanrossum commented Jul 23, 2020

Also please add a news item.

amaajemyfren and others added 5 commits July 27, 2020 23:15
@amaajemyfren
Update lexical_analysis.rst
477587e 
Change "equals" → "equal sign"
Limit line length to 80 characters with the exception of productionList
@amaajemyfren
Modified lexical_analysis.rst
aa4c12a 
Changed the index change = from equal to equals
@amaajemyfren
Update lexical_analysis.rst
725cf32 
Add index entry for symbols
@blurb-it
📜🤖 Added by blurb_it.
dfc5a89
@amaajemyfren
Update lexical_analysis.rst
69e1211 
Remove extra spaces.
@gvanrossum
Copy link
Member

gvanrossum commented Jul 27, 2020

FWIW, why are all your local commits titled “Updated ”? It would make more sense to put a description of your change in the title/subject field. (No biggie, just unusual, and more meaningful titles are helpful to reviewers. Of course the commits will all be squashed when we merge, so don’t fret. :-)

@amaajemyfren
Copy link
Contributor Author

amaajemyfren commented Jul 27, 2020

why are all your local commits titled “Updated ”?

It is a bad habit. I generally add a second line where I explain what I actually did. Sorry.

gvanrossum
gvanrossum approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll merge this. Thanks!

@miss-islington miss-islington merged commit 13efaec into python:master Jul 27, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2020

Thanks @amaajemyfren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2020

Sorry @amaajemyfren, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 13efaec2e03288d7ff0ee643589c32bde6c6973c 3.9

@miss-islington miss-islington self-assigned this Jul 27, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2020

Thanks @amaajemyfren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 27, 2020

GH-21644 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2020
@amaajemyfren @miss-islington
bpo-41045: Document debug feature of f-strings ('=') (pythonGH-21509)
d822e94 
Co-Authored-By: Rishi <[email protected]>

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 13efaec)

Co-authored-by: amaajemyfren <[email protected]>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jul 27, 2020
@amaajemyfren @gvanrossum
[3.9] bpo-41045: Document debug feature of f-strings ('=') (pythonGH-…
169ad45 
…21509)

Co-Authored-By: Rishi <[email protected]>

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 13efaec)

Co-authored-by: amaajemyfren <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jul 27, 2020

GH-21645 is a backport of this pull request to the 3.9 branch.

gvanrossum added a commit that referenced this pull request Jul 27, 2020
@gvanrossum @amaajemyfren
[3.9] bpo-41045: Document debug feature of f-strings ('=') (GH-21509) (…
e962e3f 
…GH-21645)

Co-Authored-By: Rishi <[email protected]>

(cherry picked from commit 13efaec)

Co-authored-by: amaajemyfren <[email protected]>
@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2020

Thanks @amaajemyfren for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2020

Sorry @amaajemyfren, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 13efaec2e03288d7ff0ee643589c32bde6c6973c 3.8

@bedevere-bot
Copy link

bedevere-bot commented Jul 27, 2020

GH-21647 is a backport of this pull request to the 3.8 branch.

gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jul 27, 2020
@amaajemyfren @gvanrossum
[3.8] bpo-41045: Document debug feature of f-strings ('=') (pythonGH-…
49a5587 
…21509)

Co-Authored-By: Rishi <[email protected]>

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 13efaec)

Co-authored-by: amaajemyfren <[email protected]>
gvanrossum added a commit that referenced this pull request Jul 27, 2020
@gvanrossum @amaajemyfren
[3.8] bpo-41045: Document debug feature of f-strings ('=') (GH-21509) (…
3baff21 
…#21647)

Co-Authored-By: Rishi <[email protected]>

(cherry picked from commit 13efaec)

Co-authored-by: amaajemyfren <[email protected]>
@amaajemyfren amaajemyfren deleted the proposal_issue41045 branch July 31, 2020 14:28
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
@amaajemyfren @shihai1991
bpo-41045: Document debug feature of f-strings ('=') (pythonGH-21509)
68732c1 
Co-Authored-By: Rishi <[email protected]>

Automerge-Triggered-By: @gvanrossum
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@amaajemyfren @shihai1991
bpo-41045: Document debug feature of f-strings ('=') (pythonGH-21509)
e22a2b5 
Co-Authored-By: Rishi <[email protected]>

Automerge-Triggered-By: @gvanrossum
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@amaajemyfren
bpo-41045: Document debug feature of f-strings ('=') (pythonGH-21509)
4fce445 
Co-Authored-By: Rishi <[email protected]>

Automerge-Triggered-By: @gvanrossum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amaajemyfren @gvanrossum @miss-islington @bedevere-bot @the-knights-who-say-ni