Skip to content

fix enabling compression by trimming whitespaces in accept encoding header #6952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix enabling compression by trimming whitespaces in accept encoding header #6952

merged 1 commit into from
Feb 20, 2024

Conversation

@sercand
Copy link
Contributor

@sercand sercand commented Jan 31, 2024 •
edited by arvindbr8
Loading

fixes #6951

RELEASE NOTES: none

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 31, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sercand / name: Sercan Değirmenci (3f6ec4a)

@codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Merging #6952 (3f6ec4a) into master (8d735f0) will decrease coverage by 1.46%.
Report is 21 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6952      +/-   ##
==========================================
- Coverage   83.71%   82.25%   -1.46%     
==========================================
  Files         287      296       +9     
  Lines       30926    31458     +532     
==========================================
- Hits        25889    25877      -12     
- Misses       3972     4516     +544     
  Partials     1065     1065
Files Coverage Δ
internal/transport/transport.go 92.88% <100.00%> (+0.11%) ⬆️
server.go 81.82% <ø> (+0.31%) ⬆️

... and 34 files with indirect coverage changes

arvindbr8
arvindbr8 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR @sercand

@arvindbr8 arvindbr8 requested a review from dfawley January 31, 2024 22:30
@arvindbr8 arvindbr8 added this to the 1.62 Release milestone Jan 31, 2024
@ginayeh ginayeh modified the milestones: 1.62 Release, 1.63 Release Feb 8, 2024
dfawley
dfawley requested changes Feb 15, 2024
View reviewed changes
@dfawley dfawley assigned sercand and unassigned dfawley Feb 15, 2024
@sercand sercand force-pushed the trim-compression-values branch from c918f5c to 3f6ec4a Compare February 16, 2024 08:30
@sercand sercand requested a review from dfawley February 16, 2024 08:31
dfawley
dfawley approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dfawley dfawley assigned arvindbr8 and unassigned sercand Feb 16, 2024
@arvindbr8
Copy link
Contributor

arvindbr8 commented Feb 20, 2024

LGTM. Thanks for the PR @sercand

@arvindbr8 arvindbr8 merged commit 76a23bf into grpc:master Feb 20, 2024
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Mar 4, 2024
@sercand @arvindbr8
fix enabling compression by trimming whitespaces in accept encoding h…
5948513 
…eader (grpc#6952)
@arvindbr8 arvindbr8 mentioned this pull request Mar 4, 2024
Merged
dfawley pushed a commit that referenced this pull request Mar 4, 2024
@sercand @dfawley
fix enabling compression by trimming whitespaces in accept encoding h…
d7334c4 
…eader (#6952)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dfawley dfawley dfawley approved these changes

+1 more reviewer

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arvindbr8 arvindbr8

Labels

Type: Bug

Projects

None yet

Milestone

1.63 Release

Development

Successfully merging this pull request may close these issues.

Response is not compressed when grpc-accept-encoding header contains spaces between values

4 participants

@sercand @arvindbr8 @dfawley @ginayeh