Skip to content

Response is not compressed when grpc-accept-encoding header contains spaces between values #6951

@sercand

Description

@sercand

What version of gRPC are you using?

1.61.0

What version of Go are you using (go version)?

1.21.2

What operating system (Linux, Windows, …) and version?

macOS

What did you do?

Call grpc-go server from https://github.com/grpc/grpc client with compression enabled.

What did you expect to see?

grpc-core adds a whitespace character between values:

grpc-accept-encoding=identity, deflate, gzip

go server should accept this header.

What did you see instead?

There is no compression happened between server and client.
The reason for that the go code splits the value with , and doesn't trim the results.
The only valid header for go is the following:

grpc-accept-encoding=identity,deflate,gzip

grpc-dotnet repo is has done something similar before.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions