Skip to content

Change 500 to 400 http error codes #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sungam3r wants to merge 1 commit into from
Closed

Change 500 to 400 http error codes #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/Transports.AspNetCore/GraphQLHttpMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,16 @@ await WriteErrorResponseAsync(httpResponse, writer, cancellationToken,
{
var stopwatch = ValueStopwatch.StartNew();
await RequestExecutingAsync(gqlRequest);
var result = await ExecuteRequestAsync(gqlRequest, userContext, executer, context.RequestServices, cancellationToken);
ExecutionResult result;
try
{
result = await ExecuteRequestAsync(gqlRequest, userContext, executer, context.RequestServices, cancellationToken);
}
catch (InvalidOperationException e) //TODO: find a better way for sorting 4xx from 5xx
{
await WriteErrorResponseAsync(httpResponse, writer, cancellationToken, e.Message);
return;
}

await RequestExecutedAsync(new GraphQLRequestExecutionResult(gqlRequest, result, stopwatch.Elapsed));

Expand All @@ -150,7 +159,16 @@ await WriteErrorResponseAsync(httpResponse, writer, cancellationToken,

var stopwatch = ValueStopwatch.StartNew();
await RequestExecutingAsync(gqlRequestInBatch, i);
var result = await ExecuteRequestAsync(gqlRequestInBatch, userContext, executer, context.RequestServices, cancellationToken);
ExecutionResult result;
try
{
result = await ExecuteRequestAsync(gqlRequestInBatch, userContext, executer, context.RequestServices, cancellationToken);
}
catch (InvalidOperationException e) //TODO: find a better way for sorting 4xx from 5xx
{
await WriteErrorResponseAsync(httpResponse, writer, cancellationToken, e.Message);
return;
}

await RequestExecutedAsync(new GraphQLRequestExecutionResult(gqlRequestInBatch, result, stopwatch.Elapsed, i));

Expand Down