Change 500 to 400 http error codes #493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
approved these changes
Jan 15, 2021
Member
|
The changes here should be reviewed in light of #581 and tests should be added |
Member
Author
|
Closed in favor of #584 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ideal solution.
See
DocumentExecuter.ExecuteAsync:In general, we do not know why this or that error occurred and the client or server is to blame for this. Some cases can be handled on the server side without ever passing control inside GraphQL.NET. For example, this one is just to check the query string for
nullbut in general it is impossible to predict all situations. What code should be returned? Obviously not 500.