This repository was archived by the owner on Dec 9, 2025. It is now read-only.
Unify, format, and run tests against examples #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
olegbespalov
force-pushed
the
chore/format-examples
branch
2 times, most recently
from
4298568 to
806d97e
Compare
olegbespalov
requested review from
joanlopez and
mstoykov
and removed request for
a team
olegbespalov
changed the title
mstoykov
reviewed
Apr 19, 2024
mstoykov
reviewed
Apr 19, 2024
olegbespalov
force-pushed
the
chore/format-examples
branch
from
806d97e to
2fa761d
Compare
olegbespalov
force-pushed
the
chore/format-examples
branch
from
2fa761d to
57e9fb6
Compare
mstoykov
approved these changes
Apr 19, 2024
olegbespalov
force-pushed
the
chore/format-examples
branch
from
57e9fb6 to
0bf8c97
Compare
Contributor
Author
Contributor
Author
|
@joanlopez Since this PR is mostly about auto-applying the eslint + moving things around, I'm going to merge it as it is (since I need a couple more based on it). If you have any other feedback, feel free to bring it, and I'll iterate on it separately with PRs if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Note that: import/export examples are commented on since they are actually catch a data race that should be resolved after #76
Sorry for the big PR. It's better to check by commit; the first commit could be skipped since it's auto-formating.
Why?
Unifying examples should improve the documentation and simplify their maintenance.
A pull-request starter #67 (comment)
Running the tests against examples should help with finding degradations like #68