Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@olegbespalov
Copy link
Contributor

What?

This change fixes a degradation that happened after merging the #61

I found it while working on the ECDSA support, and it seems like ECDSA was also a reason why the test case was disabled #41.

Why?

Without the change our example erroring with:

./k6 run examples/sign_verify/sign-verify-hmac.js

INFO[0000] {"name":"InvalidAccessError","message":"key algorithm does not describe a HMAC key"}  source=console

@olegbespalov olegbespalov self-assigned this Apr 10, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner April 10, 2024 13:42
@olegbespalov olegbespalov requested review from mstoykov and oleiade and removed request for a team April 10, 2024 13:42
@olegbespalov olegbespalov changed the title HNAC fix for the sign and verify HMAC fix for the sign and verify Apr 10, 2024
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

btw usually single method interfaces have er at the end of the single method name as their name. That is to say that hasHash usually should be hasher.

Not really all that important, but maybe we can fix it in another PR

@olegbespalov
Copy link
Contributor Author

Yep, and I'm trying to follow this go-convention. However, here it's not the hasher but something that has a hash() string method

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants