fix: grpcInflightLimitCheck should always call RPCCallFinished #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #749 This also updates grpc library to v1.75 where this bug is introduced, so the tests are consistent with the code. This PR adds a timer on each request that will verify whether the request actually proceeded, and if it didn't, it will call RPCCallFinished to make sure that the method limiter provided has performed the necessary cleanup. In the usual flow, we will cancel that timer as soon as we start processing the headers. Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
colega
deleted the
fix-grpcinflightlimitcheck-should-always-call-rpccallfinished
branch
4 tasks
colega
added a commit
to grafana/mimir
that referenced
this pull request
Oct 10, 2025
#### What this PR does Updated dskit to include the fix from grafana/dskit#750 See #12966 for more details about the bug. #### Which issue(s) this PR fixes or relates to Fixes #12966 #### Checklist - [ ] Tests updated. - [ ] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. Signed-off-by: Oleg Zaytsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #749
This also updates grpc library to v1.75 where this bug is introduced, so the tests are consistent with the code.
This PR adds a timer on each request that will verify whether the request actually proceeded, and if it didn't, it will call RPCCallFinished to make sure that the method limiter provided has performed the necessary cleanup.
In the usual flow, we will cancel that timer as soon as we start processing the headers.