Skip to content

Bug: grpcInflightLimitCheck doesn't always call RPCCallFinished #749

@colega

Description

@colega

This is a child issue for grafana/mimir#12966

When updating google.golang.org/grpc to v1.75 it includes the change from grpc/grpc-go#8439 which causes this statement to no longer be true:

// If we accept request (no error), eventually HandleRPC with stats.End notification will be called.

The new shortcut introduced after calling the InTapHandle causes request to be early-aborted after executing the tap handle, so RPCCallStarting was already called but RPCCallFinished will never be called.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions