fix: Update prometheus.exporter.postgresql to work properly with postgres 17
#2972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview deleted. |
wildum
approved these changes
Mar 12, 2025
Contributor
wildum
left a comment
wildum
left a comment
There was a problem hiding this comment.
lgtm, thanks for chasing this!
Contributor
Author
|
@clayton-cornell any issues with adding the note about supported version for the new collector to the list? 
|
docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md
Outdated
Show resolved
Hide resolved
clayton-cornell
approved these changes
Mar 12, 2025
Contributor
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
One minor comment for PostgreSQL as the full product name.
Contributor
I can't think of any reason not to add the info. It's important. |
…er.postgres.md Co-authored-by: Clayton Cornell <[email protected]>
Contributor
Author
Oh. I see what you mean. If we drop it into an admonition where it is now, it won't "fit" properly in the column list. |
dehaansa
added a commit
that referenced
this pull request
Mar 13, 2025
…stgres 17 (#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 3f52ee7)
Merged
dehaansa
added a commit
that referenced
this pull request
Mar 13, 2025
* remotecfg: Fix errNotModified causing incorrect last_load metric and printing invalid error logs (#2977) Fixing behavior of errNotModified and remotecfg_last_load_successful metric. This also prevents invalid error log messages from being printed. (cherry picked from commit 7350cac) * Fix attribute name in Beyla configuration. (#2966) (cherry picked from commit 5b5752a) * fix: Update `prometheus.exporter.postgresql` to work properly with postgres 17 (#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 3f52ee7) * Update changelog --------- Co-authored-by: Zachary Sistrunk <[email protected]> Co-authored-by: Rafael Roquetto <[email protected]>
towolf
pushed a commit
to towolf/alloy
that referenced
this pull request
Apr 2, 2025
…stgres 17 (grafana#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]>
towolf
pushed a commit
to towolf/alloy
that referenced
this pull request
Apr 2, 2025
…stgres 17 (grafana#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Ports the work in the upstream prometheus-community/postgres_exporter#1072 exporter to the grafana fork used in Alloy to resolve
stat_bgwritercollector issues, and add thestat_checkpointercollector.Which issue(s) this PR fixes
Fixes #2388
Notes to the Reviewer
Tested locally against a postgres17 instance installed via homebrew.
PR Checklist