Fix attribute name in Beyla configuration. #2966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
💻 Deploy preview deleted. |
clayton-cornell
added
the
type/docs
Contributor
|
No doc changes or suggestions |
wildum
approved these changes
Mar 11, 2025
Contributor
wildum
left a comment
wildum
left a comment
There was a problem hiding this comment.
LGTM, tests should be updated. It would be nice to have more examples in the doc also but can be done via another PR
Contributor
Author
|
@wildum thanks, I will track the request for improved examples at grafana/beyla#1736 so that it does not fall in the limbo. |
dehaansa
pushed a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 5b5752a)
Merged
dehaansa
added a commit
that referenced
this pull request
Mar 13, 2025
* remotecfg: Fix errNotModified causing incorrect last_load metric and printing invalid error logs (#2977) Fixing behavior of errNotModified and remotecfg_last_load_successful metric. This also prevents invalid error log messages from being printed. (cherry picked from commit 7350cac) * Fix attribute name in Beyla configuration. (#2966) (cherry picked from commit 5b5752a) * fix: Update `prometheus.exporter.postgresql` to work properly with postgres 17 (#2972) * Add support for postgres17 in prometheus.exporter.postgres * Update changelog * Update docs/sources/reference/components/prometheus/prometheus.exporter.postgres.md Co-authored-by: Clayton Cornell <[email protected]> --------- Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 3f52ee7) * Update changelog --------- Co-authored-by: Zachary Sistrunk <[email protected]> Co-authored-by: Rafael Roquetto <[email protected]>
towolf
pushed a commit
to towolf/alloy
that referenced
this pull request
Apr 2, 2025
towolf
pushed a commit
to towolf/alloy
that referenced
this pull request
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The Beyla configuration for network and application filters rely on the block label for the attribute name, i.e.
however, attribute names such as "k8s.src.owner.name" are not valid label identifiers, rendering the above config unparsable by the alloy config syntax.
This PR changes the code so that attributes need to be explicitly specified using the
attrfield:Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist