Skip to content

Allow render component inside backdrop #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gorhom merged 2 commits into from
Oct 3, 2021
Merged

Allow render component inside backdrop #662

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd203c
Allow render component inside backdrop
r0b0t3d Sep 27, 2021
9804553
resolve comments
r0b0t3d Oct 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/bottomSheetBackdrop/BottomSheetBackdrop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const BottomSheetBackdropComponent = ({
enableTouchThrough = DEFAULT_ENABLE_TOUCH_THROUGH,
pressBehavior = DEFAULT_PRESS_BEHAVIOR,
style,
children,
}: BottomSheetDefaultBackdropProps) => {
//#region hooks
const { snapToIndex, close } = useBottomSheet();
Expand Down Expand Up @@ -104,7 +105,7 @@ const BottomSheetBackdropComponent = ({
[disappearsOnIndex]
);
//#endregion

return pressBehavior !== 'none' ? (
<TapGestureHandler onGestureEvent={gestureHandler}>
<Animated.View
Expand All @@ -116,14 +117,18 @@ const BottomSheetBackdropComponent = ({
accessibilityHint={`Tap to ${
typeof pressBehavior === 'string' ? pressBehavior : 'move'
} the Bottom Sheet`}
/>
>
{children}
</Animated.View>
</TapGestureHandler>
) : (
<Animated.View
ref={containerRef}
pointerEvents={pointerEvents}
style={containerStyle}
/>
>
{children}
</Animated.View>
);
};

Expand Down
4 changes: 4 additions & 0 deletions src/components/bottomSheetBackdrop/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,8 @@ export interface BottomSheetDefaultBackdropProps
* @default 'close'
*/
pressBehavior?: BackdropPressBehavior;
/**
* Child component that will be rendered on backdrop.
*/
children?: React.ReactNode;
}