Skip to content

Conversation

@r0b0t3d
Copy link
Contributor

@r0b0t3d r0b0t3d commented Sep 27, 2021

Motivation

This PR adds an option to render child component inside default backdrop

Copy link
Owner

@gorhom gorhom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @r0b0t3d for submitting this pr, i have left some comments , once they've been addressed i will merge it :)

@gorhom gorhom added the v4 Written in Reanimated v2 label Oct 3, 2021
@r0b0t3d
Copy link
Contributor Author

r0b0t3d commented Oct 3, 2021

@gorhom I resolved comments, please help take a look. Thanks

@gorhom
Copy link
Owner

gorhom commented Oct 3, 2021

thanks @r0b0t3d for updating the PR 👍

@gorhom gorhom merged commit 5df1a1f into gorhom:master Oct 3, 2021
bulkinav pushed a commit to bulkinav/react-native-bottom-sheet that referenced this pull request Nov 4, 2021
* Allow render component inside backdrop

* resolve comments
bulkinav pushed a commit to bulkinav/react-native-bottom-sheet that referenced this pull request Dec 6, 2021
* Allow render component inside backdrop

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 Written in Reanimated v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants