chore: skip nondeterministic goroutine run result test#1564
Merged
Conversation
The goroutine test output is nondeterministic by design since multiple goroutines run concurrently without enforced execution order. The Go scheduler does not guarantee the order of goroutine execution or printed output. Setting expect.txt to ";" skips the run comparison while still allowing the IR generation test to run. Closes #1563 Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <[email protected]>
1 task
xgopilot bot
pushed a commit
that referenced
this pull request
Jan 15, 2026
Merge from PR #1564 - goroutine test output is nondeterministic by design since multiple goroutines run concurrently without enforced execution order. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1564 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 45 45
Lines 11971 11971
=======================================
Hits 10896 10896
Misses 899 899
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@xgopilot and |
Contributor
Author
Done ✓Applied the same fix to Changes:
Reason: The
The IR generation test ( |
The selects test output is nondeterministic due to concurrent goroutines and select statements without enforced execution order. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @luoliwoshang
This PR skips the run result test for
cl/_testgo/goroutineby settingexpect.txtto;.Summary
expect.txtto;skips the run comparison while still allowing the IR generation test (out.ll) to runTest plan
go test -run TestRunFromTestgo/goroutine -v ./cl/passesCloses #1563
Generated with codeagent
Co-authored-by: luoliwoshang [email protected]