cl/_testrt/cast: enable run result test#1562
Merged
Conversation
Now that issue #1538 is fixed by PR #1544, remove the skip marker (;) from expect.txt to enable the cast test. The test runs successfully with no output (it only panics on error). Closes #1561 Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 45 45
Lines 11971 11971
=======================================
Hits 10896 10896
Misses 899 899
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
resome fail because the goroutine output test is nondeterministic #1563 |
Member
Contributor
Author
Merged PR #1564 ✓Successfully merged changes from PR #1564 into this branch:
This PR now includes both:
|
Merge from PR #1564 - goroutine test output is nondeterministic by design since multiple goroutines run concurrently without enforced execution order. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @luoliwoshang
Summary
cl/_testrt/castrun result test that was previously skipped;) fromexpect.txtto enable the testTest plan
LLGO_ROOT=/workspace go test -run "TestRunFromTestrt/cast" ./cl/...Closes #1561