Skip to content

cl/_testrt/cast: enable run result test#1562

Merged
xushiwei merged 2 commits intomainfrom
xgopilot/issue-1561-1768440209
Feb 5, 2026
Merged

cl/_testrt/cast: enable run result test#1562
xushiwei merged 2 commits intomainfrom
xgopilot/issue-1561-1768440209

Conversation

@xgopilot
Copy link
Contributor

@xgopilot xgopilot bot commented Jan 15, 2026

Requested by @luoliwoshang

Summary

Test plan

  • Verified the test passes with LLGO_ROOT=/workspace go test -run "TestRunFromTestrt/cast" ./cl/...

Closes #1561

Now that issue #1538 is fixed by PR #1544, remove the skip marker (;)
from expect.txt to enable the cast test. The test runs successfully
with no output (it only panics on error).

Closes #1561

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: luoliwoshang <[email protected]>
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (475fe56) to head (2753963).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1562   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          45       45           
  Lines       11971    11971           
=======================================
  Hits        10896    10896           
  Misses        899      899           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luoliwoshang
Copy link
Member

resome fail because the goroutine output test is nondeterministic #1563

@luoliwoshang
Copy link
Member

@xgopilot merge #1564 to ignore unexpect nondeterministic outputtest

@xgopilot
Copy link
Contributor Author

xgopilot bot commented Jan 15, 2026

Merged PR #1564

Successfully merged changes from PR #1564 into this branch:

  • Change: Skip cl/_testgo/goroutine run result test by setting expect.txt to ;
  • Reason: Goroutine test output is nondeterministic by design since multiple goroutines run concurrently without enforced execution order
  • Commit: 2753963

This PR now includes both:

  1. Enable cl/_testrt/cast run result test (original change)
  2. Skip cl/_testgo/goroutine run result test (merged from chore: skip nondeterministic goroutine run result test #1564)

Merge from PR #1564 - goroutine test output is nondeterministic by design
since multiple goroutines run concurrently without enforced execution order.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: luoliwoshang <[email protected]>
Copy link
Member

@luoliwoshang luoliwoshang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xushiwei xushiwei merged commit b03e16f into main Feb 5, 2026
45 checks passed
@xgopilot xgopilot bot deleted the xgopilot/issue-1561-1768440209 branch February 5, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

recover cl/_testrt/cast/in.go 's run result test

3 participants