Skip to content

Conversation

@jgeewax
Copy link
Contributor

@jgeewax jgeewax commented May 11, 2015

Adds more padding around the code snippet on the landing page.

@jgeewax jgeewax added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. docs labels May 11, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2015
@tseaver
Copy link
Contributor

tseaver commented May 11, 2015

LGTM. Verified by toggling the styles w/ "Inspect this element" on the live docs.

dhermes added a commit that referenced this pull request May 14, 2015
Updated padding of code snippet on landing page.
@dhermes dhermes merged commit b87801a into googleapis:gh-pages May 14, 2015
@dhermes
Copy link
Contributor

dhermes commented May 14, 2015

@jgeewax FYI typically the person filing the PR does the merge (I'm not sure if this is typical on all of GitHub, but it is in our project). I figured I'd merge as this has been sitting for a few days.

@jgeewax
Copy link
Contributor Author

jgeewax commented May 14, 2015

Gotcha -- so even external contributors would do their own merging ?

@dhermes
Copy link
Contributor

dhermes commented May 14, 2015

It hasn't come up yet, but GitHub only allows project members to merge (as I've seen with oauth2client) so in those cases it'd have to be one of us.

I don't know if there is a typical approach on GitHub?

@jgeewax
Copy link
Contributor Author

jgeewax commented May 14, 2015

OK that makes sense -- outsiders would need you guys to merge. Any objection to treating my PR as you would an outsider ?

@dhermes
Copy link
Contributor

dhermes commented May 14, 2015

Fine with me (assuming you send more PRs in the future)

parthea pushed a commit that referenced this pull request Nov 22, 2025
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore(deps): update all dependencies

* Update samples/snippets/requirements.txt

---------

Co-authored-by: Chalmer Lowe <[email protected]>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@85c23b6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
Source-Link: googleapis/synthtool@85c23b6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants