Skip to content

#825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'. #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 2 commits into from
May 4, 2015
Merged

#825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'. #852

tseaver merged 2 commits into from
May 4, 2015

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented May 1, 2015

See #825.

@tseaver tseaver added the api: storage Issues related to the Cloud Storage API. label May 1, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2015
@tseaver tseaver mentioned this pull request May 1, 2015
Closed
@coveralls
Copy link

coveralls commented May 1, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 843a50e on tseaver:825-storage_property_mixin-allow_explicit_connection into fb59514 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented May 1, 2015

@dhermes PTAL

dhermes
dhermes reviewed May 4, 2015
View reviewed changes
gcloud/storage/_helpers.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes dhermes mentioned this pull request May 4, 2015
Merged
@tseaver
Copy link
Contributor Author

tseaver commented May 4, 2015

FWIW forcing use of _require_connection inside _PropertyMixin.{reload,patch} makes this a bigger PR: we have to chase all the tests in derived classes which don't set up the implicit default.

@tseaver
Copy link
Contributor Author

tseaver commented May 4, 2015

I was wrong there: the test failures were due to storage.api.get_bucket, which wasn't passing through the explicit connection to bucket.reload.

@tseaver
Copy link
Contributor Author

tseaver commented May 4, 2015

@dhermes Rebased w/ protobuf version pin fix, and changed to use _require_connection. PTAL

dhermes
dhermes reviewed May 4, 2015
View reviewed changes
gcloud/storage/_helpers.py

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented May 4, 2015

LGTM

tseaver added a commit that referenced this pull request May 4, 2015
@tseaver
Merge pull request #852 from tseaver/825-storage_property_mixin-allow…
2cdaeb2 
…_explicit_connection

#825: Allow passing explicit connection to '_PropertyMixin.{reload,patch}'.
@tseaver tseaver merged commit 2cdaeb2 into googleapis:master May 4, 2015
@tseaver tseaver deleted the 825-storage_property_mixin-allow_explicit_connection branch May 4, 2015 21:24
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
parthea pushed a commit that referenced this pull request Aug 21, 2025
@renovate-bot @gcf-owl-bot
chore(deps): update all dependencies (#852)
4fc92bc 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#852)
b65eb92 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
@daniel-sanche @gcf-owl-bot
chore: add experimental async data client (#920)
07c1344 
* feat: add new v3.0.0 API skeleton (#745)

* feat: improve rows filters (#751)

* feat: read rows query model class (#752)

* feat: implement row and cell model classes (#753)

* feat: add pooled grpc transport (#748)

* feat: implement read_rows (#762)

* feat: implement mutate rows (#769)

* feat: literal value filter (#767)

* feat: row_exists and read_row (#778)

* feat: read_modify_write and check_and_mutate_row (#780)

* feat: sharded read rows (#766)

* feat: ping and warm with metadata (#810)

* feat: mutate rows batching (#770)

* chore: restructure module paths (#816)

* feat: improve timeout structure (#819)

* fix: api errors apply to all bulk mutations

* chore: reduce public api surface (#820)

* feat: improve error group tracebacks on < py11 (#825)

* feat: optimize read_rows (#852)

* chore: add user agent suffix (#842)

* feat: optimize retries (#854)

* feat: add test proxy (#836)

* chore(tests): add conformance tests to CI for v3 (#870)

* chore(tests): turn off fast fail for conformance tets (#882)

* feat: add TABLE_DEFAULTS enum for table method arguments (#880)

* fix: pass None for retry in gapic calls (#881)

* feat: replace internal dictionaries with protos in gapic calls (#875)

* chore: optimize gapic calls (#863)

* feat: expose retryable error codes to users (#879)

* chore: update api_core submodule (#897)

* chore: merge main into experimental_v3 (#900)

* chore: pin conformance tests to v0.0.2 (#903)

* fix: bulk mutation eventual success (#909)

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
fix: remove dependency on packaging and pkg_resources (#852)
10b53d2 
* fix: remove dependency on packaging and pkg_resources

* add test case

* lint

* update docstring

* add constraint for importlib_metadata

* address feedback

* address feedback

* remove comment

* address feedback

* address feedback
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
build(deps): bump cryptography from 41.0.6 to 42.0.0 in /synthtool/gc…
8e6ce36 
…p/templates/python_library/.kokoro (#852)

Source-Link: googleapis/synthtool@e13b22b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@rwhogg
fix(zlib): Accomodate different Zlib compression levels (#852)
e7cc19a 
Different Zlib compression levels produce different
compression markers.

Co-authored-by: Zhou Wang <[email protected]>

Co-authored-by: Zhou Wang <[email protected]>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gcf-owl-bot
build(deps): bump cryptography from 41.0.6 to 42.0.0 in /synthtool/gc…
24ce5ef 
…p/templates/python_library/.kokoro (#852)

Source-Link: googleapis/synthtool@e13b22b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver @coveralls @dhermes @googlebot