Pin protorpc==0.10.0. #1134
Closed
Pin protorpc==0.10.0. #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around google/protorpc#12. Fixes: #1133.
googlebot
added
the
cla: yes
Contributor
Author
|
@dhermes PTAL: google/protorpc#12 blocks Travis for us. |
Contributor
Author
|
Obsoleted by @craigcitro's quick release of 0.11.1 with a backward-compatibility alias. |
Contributor
|
Thanks @craigcitro! Is |
Contributor
|
no one's actively working on it, though i'm happy to review patches if you're interested. TBH, though, i'm not quite sure what you mean by "proto3-compatible" -- the main way to use protorpc doesn't read |
Contributor
|
Nope was just curious. Thanks. (FWIW I didn't think my question all the way and your answer makes a lot of sense) |
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
There are some bugs in this implementation that stop generation in some APIs and result in incorrect snippets getting generated for others. Back out this feature for now so we can move forward with enabling snippetgen for all APIs.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
I accidentally merged #1134 without updating the golden files for snippetgen. This PR updates the golden files and marks the 'snippetgen' check required.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.62.0](googleapis/gapic-generator-python@v0.61.0...v0.62.0) (2022-01-28) ### Features * adds REST server-streaming support. ([#1120](googleapis/gapic-generator-python#1120)) ([812cf3e](googleapis/gapic-generator-python@812cf3e)) * expose extended operations annotations within generator ([#1145](googleapis/gapic-generator-python#1145)) ([e7bee70](googleapis/gapic-generator-python@e7bee70)) ### Bug Fixes * add special method parameters to set of reserved module names ([#1168](googleapis/gapic-generator-python#1168)) ([8078961](googleapis/gapic-generator-python@8078961)) * fix snippetgen golden file ([#1170](googleapis/gapic-generator-python#1170)) ([13b2028](googleapis/gapic-generator-python@13b2028)) * **snippetgen:** remove special handling for resource paths ([#1134](googleapis/gapic-generator-python#1134)) ([4ea2d11](googleapis/gapic-generator-python@4ea2d11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around google/protorpc#12.
Fixes: #1133.