feat: expose extended operations annotations within generator #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software-dov
requested review from
atulep,
busunkim96,
kbandes,
parthea and
vam-google
vam-google
reviewed
Jan 26, 2022
Contributor
vam-google
left a comment
vam-google
left a comment
There was a problem hiding this comment.
LGTM, but a few general questions to understand the general apporach and what to expect in future PRs.
software-dov
force-pushed
the
full-diregapic-lro
branch
from
52554bd to
a9c9b23
Compare
software-dov
force-pushed
the
full-diregapic-lro
branch
2 times, most recently
from
15688c4 to
a0b31df
Compare
software-dov
added
the
automerge
WIP add test, test fails
software-dov
force-pushed
the
full-diregapic-lro
branch
from
a0b31df to
b9960d2
Compare
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
parthea
approved these changes
Jan 28, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 28, 2022
🤖 I have created a release *beep* *boop* --- ## [0.62.0](v0.61.0...v0.62.0) (2022-01-28) ### Features * adds REST server-streaming support. ([#1120](#1120)) ([812cf3e](812cf3e)) * expose extended operations annotations within generator ([#1145](#1145)) ([e7bee70](e7bee70)) ### Bug Fixes * add special method parameters to set of reserved module names ([#1168](#1168)) ([8078961](8078961)) * fix snippetgen golden file ([#1170](#1170)) ([13b2028](13b2028)) * **snippetgen:** remove special handling for resource paths ([#1134](#1134)) ([4ea2d11](4ea2d11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Nov 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.62.0](googleapis/gapic-generator-python@v0.61.0...v0.62.0) (2022-01-28) ### Features * adds REST server-streaming support. ([#1120](googleapis/gapic-generator-python#1120)) ([812cf3e](googleapis/gapic-generator-python@812cf3e)) * expose extended operations annotations within generator ([#1145](googleapis/gapic-generator-python#1145)) ([e7bee70](googleapis/gapic-generator-python@e7bee70)) ### Bug Fixes * add special method parameters to set of reserved module names ([#1168](googleapis/gapic-generator-python#1168)) ([8078961](googleapis/gapic-generator-python@8078961)) * fix snippetgen golden file ([#1170](googleapis/gapic-generator-python#1170)) ([13b2028](googleapis/gapic-generator-python@13b2028)) * **snippetgen:** remove special handling for resource paths ([#1134](googleapis/gapic-generator-python#1134)) ([4ea2d11](googleapis/gapic-generator-python@4ea2d11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add internal generator methods to identify custom operations services.
This is a stepping-stone commit to fully support idiomatic, ergonomic LROs that follow the extended operations semantics.