Allow storage write streams to start at an offset #1325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
Merged in b877420. Thanks again! |
Author
|
Thanks @stephenplusplus ! Are you planning to do a release and/or bump the npm version? I'm looking to get these changes in tus-node-server, but I can install from my fork if necessary |
Contributor
|
There's one more PR I'd like to land first (#1320), but if that ends up needing more time, I'll do a release without it. Basically, I'll try to get a release out before 5:00 (EDT) today 🕔 |
Author
|
Sounds great, thanks. I'm happy to help out too if you need anything in particular |
Contributor
|
Thanks :) Just an update, I just opened a PR for a last minute bug report that came in. I'd like to make sure that works for the reporter, then it's release time. |
Contributor
|
Phew. 0.34.0 has landed. |
Author
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcs-resumable-upload package was updated to allow a users to specify a starting offset by making the Content-Range header configurable.
This PR allows the offset to be passed through in
Bucket#uploadandFile#createWriteStream.Should be merged after #1322, as that PR bumps
gcs-resumable-uploadto the new version.