Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Conversation

@bhstahl
Copy link

@bhstahl bhstahl commented May 16, 2016

The JSON api supports resuming an interrupted upload. This PR changes the Content-Range header to match the resuming protocol.

Closes #11

@stephenplusplus
Copy link
Contributor

Awesome, thanks! I think the linter is having problems with the semi-colons. Could you also add a couple tests? A test against the actual API would be great as well.

Also, added you to the repo. No obligations, but feel free to make 😄 changes like these in the future!

@bhstahl
Copy link
Author

bhstahl commented May 16, 2016

Ooop! Thanks for adding me. Will tidy this up and add tests 😄

@bhstahl
Copy link
Author

bhstahl commented May 16, 2016

@stephenplusplus, any ideas why the keyfile decryption is failing on the travis boxes? All tests pass locally for me (using my keyfile) with both node 0.12.14 and 4.4.4 versions.

@stephenplusplus
Copy link
Contributor

Yeah, no worries about that. Travis only runs the tests after a merge to master, just to prevent abuse. Probably a good idea to split the tests into integration and unit, but haven't gotten around to that yet.

Thanks for adding the tests! I'll pull this down and test locally as soon as I can.

@stephenplusplus stephenplusplus merged commit db4f0ba into googleapis:master May 17, 2016
@stephenplusplus
Copy link
Contributor

Thanks again @bhstahl!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants