Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,3 @@
# a single owner. This allows multiple teams to interact with librarian operations that cause
# changes to librarian state.
/.librarian/state.yaml

# Owned by all
go.work
go.work.sum
2 changes: 1 addition & 1 deletion bigtable/conformance_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ conformanceTestsHome=$rootDir/cloud-bigtable-clients-test/tests
sponge_log=$clientLibHome/sponge_log.log

cd $testProxyHome
GOWORK=off go build
go build

nohup $testProxyHome/testproxy --port $testProxyPort &
proxyPID=$!
Expand Down
203 changes: 0 additions & 203 deletions go.work

This file was deleted.

299 changes: 0 additions & 299 deletions go.work.sum

This file was deleted.

2 changes: 1 addition & 1 deletion internal/kokoro/continuous.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ runDirectoryTests() {
# internal tools only expected to work with latest go version
return
fi
GOWORK=off go test -race -v -timeout 45m "${1:-./...}" 2>&1 |
go test -race -v -timeout 45m "${1:-./...}" 2>&1 |
tee sponge_log.log
# Takes the kokoro output log (raw stdout) and creates a machine-parseable
# xUnit XML file.
Expand Down
6 changes: 3 additions & 3 deletions internal/kokoro/presubmit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ runPresubmitTests() {
fi

if [ -z ${RUN_INTEGRATION_TESTS} ]; then
GOWORK=off go test -race -v -timeout 15m -short ./... 2>&1 |
go test -race -v -timeout 15m -short ./... 2>&1 |
tee sponge_log.log
else
GOWORK=off go test -race -v -timeout 45m ./... 2>&1 |
go test -race -v -timeout 45m ./... 2>&1 |
tee sponge_log.log
fi

Expand All @@ -73,7 +73,7 @@ runPresubmitTests() {
# Add the exit codes together so we exit non-zero if any module fails.
exit_code=$(($exit_code + $?))
if [[ $PWD != *"/internal/"* ]]; then
GOWORK=off go build ./...
go build ./...
fi
exit_code=$(($exit_code + $?))
}
Expand Down
12 changes: 3 additions & 9 deletions internal/librariangen/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -137,31 +137,25 @@ Instructions

6. Run:

```
go work use ./[*library*]
```

7. Run:

```
cd [*service*] && go build ./...
```

8. Run:
7. Run:

```
git add -A && git status
```

Review the list of added files.

9. Run:
8. Run:

```
git commit -m "feat([*service*]): add new clients" -m "PiperOrigin-RevId: [*revid?791799161*]"
```

10. Open a PR with your change, make sure tests are passing, and merge.
9. Open a PR with your change, make sure tests are passing, and merge.

Here is another simpler example issue and PR: b/444451847,
[#13238](https://github.com/googleapis/google-cloud-go/pull/13238)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
global_files_allowlist:
- path: "go.work"
permissions: "read-write"
- path: "go.work.sum"
permissions: "read-write"
- path: "internal/generated/snippets/go.mod"
permissions: "read-write"
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
global_files_allowlist:
# Allow the container to read and write the root go.work file
# during the 'configure' step to add new modules.
- path: "go.work"
permissions: "read-write"

# Allow the container to read a template.
- path: "internal/README.md.template"
permissions: "read-only"
Expand Down
Loading