Skip to content

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Dec 12, 2025

This PR excises the use of go workspaces files from this repository. Over time best practices around go workspaces have evolved (https://go.dev/ref/mod#workspaces), and now guidance is generally that workspace files shouldn't be part of the tracked source control artifacts.

This PR also cleans up workspace-isms from various artifacts in the repository, including CI/CD overrides, documentation, and code generator processing.

Addresses #13393

This PR excises the use of go workspaces files from this repository.
Over time best practices around go workspaces have evolved, and now
guidance is generally that workspace files shouldn't be part of the
tracked source control artifacts.

This PR also cleans up workspace-isms from various artifacts in the
repository, including CI/CD overrides, documentation, and code
generator processing.

Addresses googleapis#13393
@shollyman shollyman requested review from a team as code owners December 12, 2025 18:53
@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 12, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the repository's Go module management by excising the use of Go workspace files. This change reflects evolving best practices in the Go ecosystem, where workspace files are generally not considered part of tracked source control artifacts. The removal of these files simplifies the repository structure and associated build, test, and code generation processes.

Highlights

  • Go Workspace Files Removed: The go.work and go.work.sum files have been completely removed from the repository, aligning with current Go best practices that discourage tracking workspace files in source control.
  • CI/CD Script Updates: Continuous Integration and Continuous Delivery (CI/CD) scripts have been updated to remove the GOWORK=off flag from go build and go test commands, simplifying the build and test processes now that workspaces are no longer in use.
  • Documentation and Configuration Cleanup: Documentation for the librariangen tool has been revised to remove instructions related to go work use, and the tool's configuration files have been updated to no longer allow read/write permissions for go.work and go.work.sum.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes Go workspace artifacts (go.work and go.work.sum) from the repository, which is a good practice as these files are typically specific to a developer's local environment. The changes are comprehensive, updating CI/CD scripts, documentation, and code generation configurations to remove any reliance on Go workspaces. The modifications are clean, consistent, and correctly implement the intended cleanup. Overall, this is a solid improvement to the repository's structure and development workflow.

hongalex
hongalex previously approved these changes Dec 12, 2025
@shollyman shollyman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 18, 2025
@shollyman shollyman merged commit fc154ca into googleapis:main Dec 18, 2025
13 checks passed
@shollyman shollyman deleted the workworkwork branch December 18, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants