-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: remove workspace artifacts from repository #13476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR excises the use of go workspaces files from this repository. Over time best practices around go workspaces have evolved, and now guidance is generally that workspace files shouldn't be part of the tracked source control artifacts. This PR also cleans up workspace-isms from various artifacts in the repository, including CI/CD overrides, documentation, and code generator processing. Addresses googleapis#13393
Summary of ChangesHello @shollyman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the repository's Go module management by excising the use of Go workspace files. This change reflects evolving best practices in the Go ecosystem, where workspace files are generally not considered part of tracked source control artifacts. The removal of these files simplifies the repository structure and associated build, test, and code generation processes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes Go workspace artifacts (go.work and go.work.sum) from the repository, which is a good practice as these files are typically specific to a developer's local environment. The changes are comprehensive, updating CI/CD scripts, documentation, and code generation configurations to remove any reliance on Go workspaces. The modifications are clean, consistent, and correctly implement the intended cleanup. Overall, this is a solid improvement to the repository's structure and development workflow.
This PR excises the use of go workspaces files from this repository. Over time best practices around go workspaces have evolved (https://go.dev/ref/mod#workspaces), and now guidance is generally that workspace files shouldn't be part of the tracked source control artifacts.
This PR also cleans up workspace-isms from various artifacts in the repository, including CI/CD overrides, documentation, and code generator processing.
Addresses #13393