Skip to content
Merged
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ bazel_dep(name = "boringssl", version = "0.20241024.0")
bazel_dep(name = "nlohmann_json", version = "3.11.3")
bazel_dep(name = "curl", version = "8.8.0.bcr.3")
bazel_dep(name = "crc32c", version = "1.1.0")
bazel_dep(name = "opentelemetry-cpp", version = "1.19.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding - what results in the abi-dumps changes? Additionally, what is the purpose of abi.dump.gz files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from using absl variant related types to using std variant types in both the Cloud C++ SDK and the OpenTelemetry library were the source of the changes. We use the abi dumps to help monitor API changes in our public types. While the dumps also contain ABI information, we do not make any ABI guarantees.

bazel_dep(name = "opentelemetry-cpp", version = "1.22.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also provide additional context into why we want to use 1.22.0 here but 1.24.0 in other places?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are limited by the modules available in the bazel central registry. There is not a v1.24.0 version of the otel module currently available in the bazel central registry.

bazel_dep(name = "rules_proto", version = "7.1.0")
bazel_dep(name = "rules_python", version = "1.6.3")
bazel_dep(name = "rules_apple", version = "4.3.2")
Expand Down
Loading