-
Notifications
You must be signed in to change notification settings - Fork 432
chore(v3): update opentelemetry version #15812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cc0957b
2ca3e7c
8ef1a91
55a375a
24a8c0e
0fdba06
d3578dd
a943ba2
9721559
baa0cbc
d5d2213
777cec3
07b9899
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,7 +34,7 @@ bazel_dep(name = "boringssl", version = "0.20241024.0") | |
| bazel_dep(name = "nlohmann_json", version = "3.11.3") | ||
| bazel_dep(name = "curl", version = "8.8.0.bcr.3") | ||
| bazel_dep(name = "crc32c", version = "1.1.0") | ||
| bazel_dep(name = "opentelemetry-cpp", version = "1.19.0") | ||
| bazel_dep(name = "opentelemetry-cpp", version = "1.22.0") | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would you also provide additional context into why we want to use 1.22.0 here but 1.24.0 in other places?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are limited by the modules available in the bazel central registry. There is not a v1.24.0 version of the otel module currently available in the bazel central registry. |
||
| bazel_dep(name = "rules_proto", version = "7.1.0") | ||
| bazel_dep(name = "rules_python", version = "1.6.3") | ||
| bazel_dep(name = "rules_apple", version = "4.3.2") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding - what results in the abi-dumps changes? Additionally, what is the purpose of abi.dump.gz files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from using
abslvariant related types to usingstdvariant types in both the Cloud C++ SDK and the OpenTelemetry library were the source of the changes. We use the abi dumps to help monitor API changes in our public types. While the dumps also contain ABI information, we do not make any ABI guarantees.