-
Notifications
You must be signed in to change notification settings - Fork 432
chore(v3): update opentelemetry version #15812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v3): update opentelemetry version #15812
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15812 +/- ##
======================================================
- Coverage 92.95% 92.94% -0.02%
======================================================
Files 2451 2451
Lines 226936 226936
======================================================
- Hits 210954 210926 -28
- Misses 15982 16010 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| bazel_dep(name = "nlohmann_json", version = "3.11.3") | ||
| bazel_dep(name = "curl", version = "8.8.0.bcr.3") | ||
| bazel_dep(name = "crc32c", version = "1.1.0") | ||
| bazel_dep(name = "opentelemetry-cpp", version = "1.19.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my understanding - what results in the abi-dumps changes? Additionally, what is the purpose of abi.dump.gz files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from using absl variant related types to using std variant types in both the Cloud C++ SDK and the OpenTelemetry library were the source of the changes. We use the abi dumps to help monitor API changes in our public types. While the dumps also contain ABI information, we do not make any ABI guarantees.
| bazel_dep(name = "curl", version = "8.8.0.bcr.3") | ||
| bazel_dep(name = "crc32c", version = "1.1.0") | ||
| bazel_dep(name = "opentelemetry-cpp", version = "1.19.0") | ||
| bazel_dep(name = "opentelemetry-cpp", version = "1.22.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you also provide additional context into why we want to use 1.22.0 here but 1.24.0 in other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are limited by the modules available in the bazel central registry. There is not a v1.24.0 version of the otel module currently available in the bazel central registry.
| -DBUILD_SHARED_LIBS=yes \ | ||
| -DWITH_EXAMPLES=OFF \ | ||
| -DWITH_STL=CXX14 \ | ||
| -DWITH_ABSEIL=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is related to the point about ceasing trying to get OTel to work with Abseil as described in the PR description. Out of curiosity, was the historical context for the compatibility between otel and abseil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So OTel strives to work across several C++ standards, Abseil is one way to get variant related types when using C++14 or earlier. OTel also provides its own implementations of STL types in its nostd namespace. As I understand it, the nostd types in OTel are aimed at providing lightweight alternatives to STL types for applications in resource contrained environments. OTel's nostd is the default, so in order to use the STL we need to build it with the appropriate CMake flag. Enabling both WITH_STL and WITH_ABSEIL was a bad idea, we needed to choose one or the other.
8170800
into
googleapis:prepare-for-v3.0.0
Uh oh!
There was an error while loading. Please reload this page.