Skip to content

Conversation

@MaximilianMeister
Copy link
Contributor

kubernetes/kubernetes#65204

Signed-off-by: Maximilian Meister [email protected]

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Collaborator

Hi @MaximilianMeister. Thanks for your PR.

I'm waiting for a kubernetes or google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaximilianMeister
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dashpole
Copy link
Collaborator

/ok-to-test

@dashpole
Copy link
Collaborator

This looks reasonable to me, although it makes the brtfs-specific code even more complex.
cc @flavio @dmrub who have made improvements to this in the past in-case (and likely are more familiar with brtfs than I am), in-case they have any comments

@flavio
Copy link
Contributor

flavio commented Jun 20, 2018

@dashpole the change looks good to me. I worked with @MaximilianMeister on that ;)

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to hear. LGTM

@dashpole dashpole merged commit 179330d into google:master Jun 20, 2018
@MaximilianMeister MaximilianMeister deleted the fix-kubernetes-issue-65204 branch June 21, 2018 06:06
dashpole added a commit that referenced this pull request Jun 21, 2018
dashpole added a commit that referenced this pull request Jun 21, 2018
dashpole added a commit that referenced this pull request Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants