-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix kubernetes issue #65204 #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kubernetes issue #65204 #1971
Conversation
kubernetes/kubernetes#65204 Signed-off-by: Maximilian Meister <[email protected]>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
Hi @MaximilianMeister. Thanks for your PR. I'm waiting for a kubernetes or google member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! |
|
/ok-to-test |
|
@dashpole the change looks good to me. I worked with @MaximilianMeister on that ;) |
dashpole
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to hear. LGTM
kubernetes/kubernetes#65204
Signed-off-by: Maximilian Meister [email protected]