Dont watch "*.mount" cgroups #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I tested this by adding a log line right before we add an inotify watch. I verified that before this change, we see .mount cgroups being watched. After the change, we no longer see .mount cgroups being watched. |
Contributor
|
I think this is the right thing to do since watching those cgroups exhausts node resources easily. /cc @derekwaynecarr |
yujuhong
approved these changes
Jun 14, 2018
yujuhong
reviewed
Jun 14, 2018
| // Watches the specified directory and all subdirectories. Returns whether the path was | ||
| // already being watched and an error (if any). | ||
| func (self *rawContainerWatcher) watchDirectory(events chan watcher.ContainerEvent, dir string, containerName string) (bool, error) { | ||
| if strings.HasSuffix(containerName, ".mount") { |
Contributor
There was a problem hiding this comment.
Need a comment explaining why :-)
dashpole
force-pushed
the
dont_watch_mount
branch
from
9a77393 to
bc7e1cb
Compare
Collaborator
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already don't collect metrics on .mount cgroups. But watching each of the mount cgroups for sub-cgroups can use up all of the inotify watches on the node. This change now makes the watcher ignore .mount cgroups.