Skip to content

fix(core): strip trailing periods from error URLs #28054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
terminalchai wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −3
Open

fix(core): strip trailing periods from error URLs #28054

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b49aa1
fix(core): strip trailing periods from error URLs
terminalchai Jun 19, 2026
f0a1590
fix(core): handle nullish error messages
terminalchai Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/core/src/utils/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,20 @@ describe('getErrorMessage', () => {
};
expect(getErrorMessage(error)).toBe('Bad Request Message');
});

it('should remove a trailing period from URLs in error messages', () => {
const error = new Error('Migrate to https://antigravity.google.');

expect(getErrorMessage(error)).toBe(
'Migrate to https://antigravity.google',
);
});

it('should preserve periods that do not trail a URL', () => {
expect(getErrorMessage(new Error('Authentication failed.'))).toBe(
'Authentication failed.',
);
});
});

describe('isAbortError', () => {
Expand Down
11 changes: 8 additions & 3 deletions packages/core/src/utils/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,14 @@ export function isAbortError(error: unknown): boolean {
return error instanceof Error && error.name === 'AbortError';
}

function stripTrailingPeriodsFromUrls(message: string): string {
return message.replace(/(https?:\/\/\S+)\.(?=\s|$)/g, '$1');
}
Comment thread
terminalchai marked this conversation as resolved.
Outdated

export function getErrorMessage(error: unknown): string {
const friendlyError = toFriendlyError(error);
if (friendlyError instanceof Error) {
return friendlyError.message;
return stripTrailingPeriodsFromUrls(friendlyError.message);
}
if (
typeof friendlyError === 'object' &&
Expand All @@ -45,10 +49,11 @@ export function getErrorMessage(error: unknown): string {
typeof (friendlyError as { message: unknown }).message === 'string'
) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
return (friendlyError as { message: string }).message;
const message = (friendlyError as { message: string }).message;
return stripTrailingPeriodsFromUrls(message);
}
try {
return String(friendlyError);
return stripTrailingPeriodsFromUrls(String(friendlyError));
} catch {
return 'Failed to get error details';
}
Expand Down