Skip to content

fix(core): strip trailing periods from error URLs#28054

Open
terminalchai wants to merge 2 commits into
google-gemini:mainfrom
terminalchai:fix/error-url-trailing-period
Open

fix(core): strip trailing periods from error URLs#28054
terminalchai wants to merge 2 commits into
google-gemini:mainfrom
terminalchai:fix/error-url-trailing-period

Conversation

@terminalchai

Copy link
Copy Markdown

Summary

Removes sentence-ending periods that are attached directly to HTTP(S) URLs in error messages so rendered links remain navigable.

Details

  • Normalizes URL punctuation in all string-producing branches of getErrorMessage.
  • Preserves periods that do not directly trail a URL.
  • Adds regression coverage for the https://antigravity.google. case.

Related Issues

Fixes #28052

How to Validate

Run:

npm test -w @google/gemini-cli-core -- src/utils/errors.test.ts
npm run typecheck -w @google/gemini-cli-core
npx eslint packages/core/src/utils/errors.ts packages/core/src/utils/errors.test.ts --max-warnings 0
npx prettier --check packages/core/src/utils/errors.ts packages/core/src/utils/errors.test.ts

Expected:

  • All 31 focused tests pass.
  • Typecheck, ESLint, and Prettier complete successfully.
  • Migrate to https://antigravity.google. becomes Migrate to https://antigravity.google.
  • Authentication failed. remains unchanged.

Pre-Merge Checklist

  • Updated relevant documentation and README (not needed)
  • Added/updated tests
  • Noted breaking changes (none)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@terminalchai terminalchai requested a review from a team as a code owner June 19, 2026 22:13
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the usability of error messages by automatically removing trailing periods that are incorrectly appended to URLs. By normalizing these strings, the change ensures that URLs rendered in error outputs are navigable, while maintaining existing punctuation for non-URL text.

Highlights

  • URL Normalization: Introduced a utility function to strip trailing periods from HTTP(S) URLs in error messages to ensure links remain clickable.
  • Regression Testing: Added new test cases to verify that URLs are correctly cleaned while preserving periods in standard sentence structures.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the size/s A small PR label Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

📊 PR Size: size/S

  • Lines changed: 37
  • Additions: +34
  • Deletions: -3
  • Files changed: 2

@google-cla

google-cla Bot commented Jun 19, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helper function stripTrailingPeriodsFromUrls to clean up trailing periods from URLs in error messages, applying it to various error message resolution paths in getErrorMessage, and adds corresponding unit tests. The reviewer's feedback correctly points out a potential runtime TypeError if the error message is nullish, and suggests making the helper function robust against null or undefined inputs.

Comment thread packages/core/src/utils/errors.ts Outdated
@gemini-cli gemini-cli Bot added priority/p2 Important but can be addressed in a future release. area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! priority/p2 Important but can be addressed in a future release. size/s A small PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Trailing '.' in antigravity.google URL in error message causes link to not load

1 participant