-
Notifications
You must be signed in to change notification settings - Fork 13k
fix(ui): unify Ctrl+O expansion hint experience across buffer modes #21474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,6 @@ import type { ConfirmingToolState } from '../hooks/useConfirmingTool.js'; | |
| import { OverflowProvider } from '../contexts/OverflowContext.js'; | ||
| import { ShowMoreLines } from './ShowMoreLines.js'; | ||
| import { StickyHeader } from './StickyHeader.js'; | ||
| import { useAlternateBuffer } from '../hooks/useAlternateBuffer.js'; | ||
| import type { SerializableConfirmationDetails } from '@google/gemini-cli-core'; | ||
| import { useUIActions } from '../contexts/UIActionsContext.js'; | ||
|
|
||
|
|
@@ -43,7 +42,6 @@ export const ToolConfirmationQueue: React.FC<ToolConfirmationQueueProps> = ({ | |
| }) => { | ||
| const config = useConfig(); | ||
| const { getPreferredEditor } = useUIActions(); | ||
| const isAlternateBuffer = useAlternateBuffer(); | ||
| const { | ||
| mainAreaWidth, | ||
| terminalHeight, | ||
|
|
@@ -157,10 +155,5 @@ export const ToolConfirmationQueue: React.FC<ToolConfirmationQueueProps> = ({ | |
| </> | ||
| ); | ||
|
|
||
| return isAlternateBuffer ? ( | ||
| /* Shadow the global provider to maintain isolation in ASB mode. */ | ||
| <OverflowProvider>{content}</OverflowProvider> | ||
| ) : ( | ||
| content | ||
| ); | ||
| return <OverflowProvider>{content}</OverflowProvider>; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this defaulting to the alternate buffer version rather than the regular version? these changes should be making alternate buffer mode more like regular mode as far as this goes not vice vesa.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment |
||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we be just returning content rather than always wrapping in an overflow provider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For FolderTrustDialog.tsx and the ToolConfirmationQueue.tsx, the wrapper helps prevent any overflowing elements w/in these drawers/dialogs from triggering the global hint. At least initially, it allows just their local ShowMoreLine components to render. Without the wrappers we get something like this when they have overflow: https://screenshot.googleplex.com/37BxeV57LD29Mds.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fine for now. please cleanup in a followup so we show the overflow hint with an appropriate message in the main area to keep this simple.