Skip to content

Disable failing eval test #19455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrstnb merged 2 commits into from
Feb 18, 2026
Merged

Disable failing eval test #19455

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fe49cc
Disable failing eval test
chrstnb Feb 18, 2026
15fcd77
Address comment and make non-blocking
chrstnb Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions evals/hierarchical_memory.eval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,9 @@

import { describe, expect } from 'vitest';
import { evalTest } from './test-helper.js';
import {
assertModelHasOutput,
checkModelOutputContent,
} from '../integration-tests/test-helper.js';

describe('Hierarchical Memory', () => {
const TEST_PREFIX = 'Hierarchical memory test: ';
import { assertModelHasOutput } from '../integration-tests/test-helper.js';

describe.skip('Hierarchical Memory', () => {
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling this test makes sense as a temporary fix to unblock other work. To ensure it's not forgotten, please add a TODO comment with a tracking issue reference. This will help ensure the test is re-enabled once the underlying model overload issues are resolved, preventing potential future regressions.

Suggested change
describe.skip('Hierarchical Memory', () => {
// TODO(#issue): Re-enable this test suite once model overload issues are resolved.
describe.skip('Hierarchical Memory', () => {

const conflictResolutionTest =
'Agent follows hierarchy for contradictory instructions';
evalTest('ALWAYS_PASSES', {
Copy link
Copy Markdown
Member

@gundermanc gundermanc Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to USUALLY_PASSES instead.

Copy link
Copy Markdown
Member

@gundermanc gundermanc Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes it non-CI blocking.

Expand Down
Loading