Conversation
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request temporarily disables a specific evaluation test that was consistently failing due to timeouts and model overload errors. The primary purpose is to unblock the merge process for other critical pull requests that were being held up by this unreliable test. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
evals/hierarchical_memory.eval.ts
Outdated
| describe.skip('Hierarchical Memory', () => { | ||
| const conflictResolutionTest = | ||
| 'Agent follows hierarchy for contradictory instructions'; | ||
| evalTest('ALWAYS_PASSES', { |
There was a problem hiding this comment.
Please change this to USUALLY_PASSES instead.
There was a problem hiding this comment.
That makes it non-CI blocking.
There was a problem hiding this comment.
Code Review
This pull request disables the 'Hierarchical Memory' evaluation test suite, which is currently failing due to model overload errors and blocking other merges. This is a pragmatic temporary solution. The recommendation to include a TODO comment with a tracking issue reference is kept as it aligns with good practice for managing temporary fixes and ensuring test coverage is restored.
evals/hierarchical_memory.eval.ts
Outdated
| const TEST_PREFIX = 'Hierarchical memory test: '; | ||
| import { assertModelHasOutput } from '../integration-tests/test-helper.js'; | ||
|
|
||
| describe.skip('Hierarchical Memory', () => { |
There was a problem hiding this comment.
Disabling this test makes sense as a temporary fix to unblock other work. To ensure it's not forgotten, please add a TODO comment with a tracking issue reference. This will help ensure the test is re-enabled once the underlying model overload issues are resolved, preventing potential future regressions.
| describe.skip('Hierarchical Memory', () => { | |
| // TODO(#issue): Re-enable this test suite once model overload issues are resolved. | |
| describe.skip('Hierarchical Memory', () => { |
|
Size Change: -2 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
Summary
This is failing in multiple places and blocking merges of critical PRs because it's exceeding the timeout because of model overloaded errors
Temporarily disabling it to unblock folks
Example: https://github.com/google-gemini/gemini-cli/actions/runs/22149067171/job/64045531463
Details
Related Issues
How to Validate
Pre-Merge Checklist