Skip to content

Disable failing eval test#19455

Merged
chrstnb merged 2 commits intomainfrom
cb/disableeval
Feb 18, 2026
Merged

Disable failing eval test#19455
chrstnb merged 2 commits intomainfrom
cb/disableeval

Conversation

@chrstnb
Copy link
Copy Markdown
Contributor

@chrstnb chrstnb commented Feb 18, 2026

Summary

This is failing in multiple places and blocking merges of critical PRs because it's exceeding the timeout because of model overloaded errors

Temporarily disabling it to unblock folks

Example: https://github.com/google-gemini/gemini-cli/actions/runs/22149067171/job/64045531463

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@chrstnb chrstnb requested a review from a team as a code owner February 18, 2026 19:08
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily disables a specific evaluation test that was consistently failing due to timeouts and model overload errors. The primary purpose is to unblock the merge process for other critical pull requests that were being held up by this unreliable test.

Highlights

  • Test Disablement: The 'Hierarchical Memory' evaluation test has been temporarily disabled to prevent it from failing and blocking critical pull request merges.
Changelog
  • evals/hierarchical_memory.eval.ts
    • Disabled the 'Hierarchical Memory' test suite using describe.skip.
    • Removed the unused checkModelOutputContent import.
    • Removed the unused TEST_PREFIX constant.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

describe.skip('Hierarchical Memory', () => {
const conflictResolutionTest =
'Agent follows hierarchy for contradictory instructions';
evalTest('ALWAYS_PASSES', {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to USUALLY_PASSES instead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes it non-CI blocking.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the 'Hierarchical Memory' evaluation test suite, which is currently failing due to model overload errors and blocking other merges. This is a pragmatic temporary solution. The recommendation to include a TODO comment with a tracking issue reference is kept as it aligns with good practice for managing temporary fixes and ensuring test coverage is restored.

const TEST_PREFIX = 'Hierarchical memory test: ';
import { assertModelHasOutput } from '../integration-tests/test-helper.js';

describe.skip('Hierarchical Memory', () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Disabling this test makes sense as a temporary fix to unblock other work. To ensure it's not forgotten, please add a TODO comment with a tracking issue reference. This will help ensure the test is re-enabled once the underlying model overload issues are resolved, preventing potential future regressions.

Suggested change
describe.skip('Hierarchical Memory', () => {
// TODO(#issue): Re-enable this test suite once model overload issues are resolved.
describe.skip('Hierarchical Memory', () => {

@gemini-cli gemini-cli bot added the priority/p1 Important and should be addressed in the near term. label Feb 18, 2026
@chrstnb chrstnb requested a review from gundermanc February 18, 2026 19:10
@chrstnb chrstnb enabled auto-merge February 18, 2026 19:11
@github-actions
Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 24.5 MB -2 B (0%)
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@chrstnb chrstnb added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 8a88266 Feb 18, 2026
27 checks passed
@chrstnb chrstnb deleted the cb/disableeval branch February 18, 2026 19:37
tripleyoung pushed a commit to tripleyoung/gemini-cli that referenced this pull request Feb 27, 2026
tripleyoung pushed a commit to tripleyoung/gemini-cli that referenced this pull request Feb 27, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants