Added "" as default value, since getText() used to expect a string only and thus crashed when undefined... Fixes #18076

[019-Abhi]

Summary

Fixes a runtime crash in the VS Code IDE companion where rightDoc.getText() may, instead of a string value, return undefined, leading to a TypeError.

Details

Updated to use null-coalescing (?? "") when retrieving content from rightDoc.getText() to prevent TypeError when getText() was undefined

Fixes #18076

[gemini-code-assist]

Summary of Changes

Hello @019-Abhi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical runtime crash within the VS Code IDE companion. The issue stemmed from rightDoc.getText() unexpectedly returning undefined, leading to a TypeError when subsequent operations expected a string. By introducing the null-coalescing operator, the code now gracefully handles undefined values by defaulting to an empty string, thereby enhancing the stability and robustness of the application.

Highlights

• Bug Fix: Addressed a runtime crash in the VS Code IDE companion caused by rightDoc.getText() returning undefined.
• Null-Coalescing Operator: Implemented the null-coalescing operator (?? '') to provide an empty string as a default value when getText() might return undefined, preventing a TypeError.
• File Modified: The fix was applied in packages/vscode-ide-companion/src/diff-manager.ts at three distinct locations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a potential runtime crash by ensuring that the value retrieved from rightDoc.getText() is always a string. The change uses the nullish coalescing operator (?? '') to provide an empty string as a default value if getText() returns undefined. This is applied consistently in closeDiff, acceptDiff, and cancelDiff methods, correctly preventing TypeError exceptions and ensuring that subsequent operations that expect a string, like Zod schema parsing, do not fail. The fix is correct and well-targeted.

[019-Abhi]

hey @scidomino could you please review my pr when you have the time...
Thanks!

[019-Abhi]

Hey @scidomino really sorry but some tests failed while in the queue because i had synced my fork with upstream and not pushed... could you approve this again please no changes made to the files :)

[019-Abhi]

Hey, I noticed the nightly run failed with an app-id error. It looks like a secrets access issue with the create-github-app-token action on fork PRs. Just wanted to flag it in case it blocks the merge..