Skip to content

Alternate Buffer SettingsDialog #15840

@psinha40898

Description

@psinha40898

What would you like to be added?

Alternate buffer mode should render a version of the SettingsDialog that supports the new Scrolling components as well as mouse support.

Why is this needed?

It is a natural extension of the alternate buffer capabilities.

Additional context

The current SettingsDialog has excessive and redundant React State as well as Effect. The current implementation of the SettingsContext mandates that views reactive to Settings changes use React anti patterns.
It makes sense that all of this should be cleaned up before landing a conditionally rendered alternate buffer SettingsDialog for a few reasons:

  1. The Alternate Buffer version should not ship with the React Anti Pattern
  2. It will be easier to review
  3. The non Alternate Buffer version of the SettingsDialog should be easy to maintain too

A full path toward refactor is outlined in #14915
The refactor path is related to #18980
The refactor path is related to #19093
The alternate buffer settings dialog is related to #10673
The alternate buffer settings dialog is related to #18441 and #17998 but maybe those can reasonably be hot fixed without regard for this refactor path

Just referencing the issues for clarity and context

Metadata

Metadata

Assignees

Labels

area/coreIssues related to User Interface, OS Support, Core Functionalityhelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!kind/customer-issueIssues that were reported by customerspriority/p2Important but can be addressed in a future release.
No fields configured for Feature.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions