-
Notifications
You must be signed in to change notification settings - Fork 13k
Alternate Buffer SettingsDialog #15840
Copy link
Copy link
Open
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalityhelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!We will accept PRs from all issues marked as "help wanted". Thanks for your support!kind/customer-issueIssues that were reported by customersIssues that were reported by customerspriority/p2Important but can be addressed in a future release.Important but can be addressed in a future release.
Metadata
Metadata
Assignees
Labels
area/coreIssues related to User Interface, OS Support, Core FunctionalityIssues related to User Interface, OS Support, Core Functionalityhelp wantedWe will accept PRs from all issues marked as "help wanted". Thanks for your support!We will accept PRs from all issues marked as "help wanted". Thanks for your support!kind/customer-issueIssues that were reported by customersIssues that were reported by customerspriority/p2Important but can be addressed in a future release.Important but can be addressed in a future release.
Type
Fields
Give feedbackNo fields configured for Feature.
What would you like to be added?
Alternate buffer mode should render a version of the
SettingsDialogthat supports the new Scrolling components as well as mouse support.Why is this needed?
It is a natural extension of the alternate buffer capabilities.
Additional context
The current
SettingsDialoghas excessive and redundant React State as well as Effect. The current implementation of theSettingsContextmandates that views reactive to Settings changes use React anti patterns.It makes sense that all of this should be cleaned up before landing a conditionally rendered alternate buffer SettingsDialog for a few reasons:
SettingsDialogshould be easy to maintain tooA full path toward refactor is outlined in #14915
The refactor path is related to #18980
The refactor path is related to #19093
The alternate buffer settings dialog is related to #10673
The alternate buffer settings dialog is related to #18441 and #17998 but maybe those can reasonably be hot fixed without regard for this refactor path
Just referencing the issues for clarity and context