Skip to content

Fix issue with examples being included in wheel. #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethanluoyc wants to merge 3 commits into from
Closed

Fix issue with examples being included in wheel. #132

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1734f0
Fix issue with examples being included in wheel.
ethanluoyc Oct 27, 2023
48dfde5
Use namespace packages
ethanluoyc Nov 1, 2023
2767510
Keep tests in wheel
ethanluoyc Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"""Install script for setuptools."""

import os
from setuptools import find_namespace_packages
from setuptools import find_packages
Copy link
Member

@hbq1 hbq1 Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change necessary?

Copy link
Author

@ethanluoyc ethanluoyc Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think rlax is a namespace so find_packages should suffice. find_namespace_packages add docs to the package which is not desired (I can exclude that of course).

Copy link
Author

@ethanluoyc ethanluoyc Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think you are suggesting this because dm-haiku uses this. But I just realized that dm-haiku has a similar problem, I will open another issue there as well.

from setuptools import setup

_CURRENT_DIR = os.path.dirname(os.path.abspath(__file__))
Expand Down Expand Up @@ -52,7 +52,7 @@ def _parse_requirements(path):
long_description_content_type='text/markdown',
author_email='rlax-dev@google.com',
keywords='reinforcement-learning python machine learning',
packages=find_namespace_packages(exclude=['*_test.py']),
packages=find_packages(exclude=['*_test.py', 'examples']),
install_requires=_parse_requirements(
os.path.join(_CURRENT_DIR, 'requirements', 'requirements.txt')),
tests_require=_parse_requirements(
Expand Down