Fix issue with examples being included in wheel.#132
Closed
ethanluoyc wants to merge 3 commits intogoogle-deepmind:mainfrom
Closed
Fix issue with examples being included in wheel.#132ethanluoyc wants to merge 3 commits intogoogle-deepmind:mainfrom
ethanluoyc wants to merge 3 commits intogoogle-deepmind:mainfrom
Conversation
hbq1
reviewed
Nov 1, 2023
setup.py
Outdated
|
|
||
| import os | ||
| from setuptools import find_namespace_packages | ||
| from setuptools import find_packages |
Author
There was a problem hiding this comment.
I don't think rlax is a namespace so find_packages should suffice. find_namespace_packages add docs to the package which is not desired (I can exclude that of course).
Author
There was a problem hiding this comment.
OK, I think you are suggesting this because dm-haiku uses this. But I just realized that dm-haiku has a similar problem, I will open another issue there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples directory should not be included in the package.