Skip to content

Conversation

@MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

cherry-pick of #22148

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang changed the title [cherry-pick]Make offline installer optional release 2.13.0 [cherry-pick]Make offline installer optional on release 2.13.0 Oct 20, 2025
…e and log container only when we need to build offline_installer

Signed-off-by: my036811 <[email protected]>
@MinerYang MinerYang force-pushed the make-offline-installer-optional-release-2.13.0 branch from cbbb299 to b6d60e2 Compare October 20, 2025 11:07
@MinerYang MinerYang added the release-note/update Update or Fix label Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.13.0@9ff0635). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.13.0   #22476   +/-   ##
=================================================
  Coverage                  ?   46.52%           
=================================================
  Files                     ?      253           
  Lines                     ?    14235           
  Branches                  ?     2925           
=================================================
  Hits                      ?     6623           
  Misses                    ?     7260           
  Partials                  ?      352           
Flag Coverage Δ
unittests 46.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OrlinVasilev OrlinVasilev requested a review from Vad1mo October 20, 2025 11:45
@MinerYang MinerYang merged commit 5b768a2 into goharbor:release-2.13.0 Oct 21, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants