Skip to content

Commit cbbb299

Browse files
committed
[cherry-pick]add BUILD_INSTALLER parameter to optionally build prepare and log container only when we need to build offline_installer
Signed-off-by: my036811 <[email protected]>
1 parent e0b14cc commit cbbb299

File tree

2 files changed

+36
-6
lines changed

2 files changed

+36
-6
lines changed

Makefile

Lines changed: 28 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,12 @@ VERSIONTAG=dev
9292
BUILD_BASE=true
9393
PUSHBASEIMAGE=false
9494
BASEIMAGETAG=dev
95-
BUILDBASETARGET=trivy-adapter core db jobservice log nginx portal prepare redis registry registryctl exporter
95+
# for skip build prepare and log container while BUILD_INSTALLER=false
96+
BUILD_INSTALLER=true
97+
BUILDBASETARGET=trivy-adapter core db jobservice nginx portal redis registry registryctl exporter
98+
ifeq ($(BUILD_INSTALLER), true)
99+
BUILDBASETARGET += prepare log
100+
endif
96101
IMAGENAMESPACE=goharbor
97102
BASEIMAGENAMESPACE=goharbor
98103
# #input true/false only
@@ -238,10 +243,8 @@ REGISTRYUSER=
238243
REGISTRYPASSWORD=
239244

240245
# cmds
241-
DOCKERSAVE_PARA=$(DOCKER_IMAGE_NAME_PREPARE):$(VERSIONTAG) \
242-
$(DOCKERIMAGENAME_PORTAL):$(VERSIONTAG) \
246+
DOCKERSAVE_PARA=$(DOCKERIMAGENAME_PORTAL):$(VERSIONTAG) \
243247
$(DOCKERIMAGENAME_CORE):$(VERSIONTAG) \
244-
$(DOCKERIMAGENAME_LOG):$(VERSIONTAG) \
245248
$(DOCKERIMAGENAME_DB):$(VERSIONTAG) \
246249
$(DOCKERIMAGENAME_JOBSERVICE):$(VERSIONTAG) \
247250
$(DOCKERIMAGENAME_REGCTL):$(VERSIONTAG) \
@@ -250,6 +253,18 @@ DOCKERSAVE_PARA=$(DOCKER_IMAGE_NAME_PREPARE):$(VERSIONTAG) \
250253
$(IMAGENAMESPACE)/nginx-photon:$(VERSIONTAG) \
251254
$(IMAGENAMESPACE)/registry-photon:$(VERSIONTAG)
252255

256+
ifeq ($(BUILD_INSTALLER), true)
257+
DOCKERSAVE_PARA+= $(DOCKER_IMAGE_NAME_PREPARE):$(VERSIONTAG) \
258+
$(DOCKERIMAGENAME_LOG):$(VERSIONTAG)
259+
endif
260+
261+
ifeq ($(TRIVYFLAG), true)
262+
DOCKERSAVE_PARA+= $(IMAGENAMESPACE)/trivy-adapter-photon:$(VERSIONTAG)
263+
endif
264+
ifeq ($(EXPORTERFLAG), true)
265+
DOCKERSAVE_PARA+= $(DOCKERIMAGENAME_EXPORTER):$(VERSIONTAG)
266+
endif
267+
253268
PACKAGE_OFFLINE_PARA=-zcvf harbor-offline-installer-$(PKGVERSIONTAG).tgz \
254269
$(HARBORPKG)/$(DOCKERIMGFILE).$(VERSIONTAG).tar.gz \
255270
$(HARBORPKG)/prepare \
@@ -394,6 +409,7 @@ build:
394409
-e TRIVYVERSION=$(TRIVYVERSION) -e TRIVYADAPTERVERSION=$(TRIVYADAPTERVERSION) \
395410
-e VERSIONTAG=$(VERSIONTAG) \
396411
-e BUILDREG=$(BUILDREG) -e BUILDTRIVYADP=$(BUILDTRIVYADP) \
412+
-e BUILD_INSTALLER=$(BUILD_INSTALLER) \
397413
-e NPM_REGISTRY=$(NPM_REGISTRY) -e BASEIMAGETAG=$(BASEIMAGETAG) -e IMAGENAMESPACE=$(IMAGENAMESPACE) -e BASEIMAGENAMESPACE=$(BASEIMAGENAMESPACE) \
398414
-e REGISTRYURL=$(REGISTRYURL) \
399415
-e TRIVY_DOWNLOAD_URL=$(TRIVY_DOWNLOAD_URL) -e TRIVY_ADAPTER_DOWNLOAD_URL=$(TRIVY_ADAPTER_DOWNLOAD_URL) \
@@ -440,7 +456,14 @@ package_online: update_prepare_version
440456
@rm -rf $(HARBORPKG)
441457
@echo "Done."
442458

443-
package_offline: update_prepare_version compile build
459+
.PHONY: check_buildinstaller
460+
check_buildinstaller:
461+
@if [ "$(BUILD_INSTALLER)" != "true" ]; then \
462+
echo "Must set BUILD_INSTALLER as true while triggering package_offline build" ; \
463+
exit 1; \
464+
fi
465+
466+
package_offline: check_buildinstaller update_prepare_version compile build
444467

445468
@echo "packing offline package ..."
446469
@cp -r make $(HARBORPKG)

make/photon/Makefile

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,17 @@ define _build_base
233233
fi
234234
endef
235235

236-
build: _build_prepare _build_db _build_portal _build_core _build_jobservice _build_log _build_nginx _build_registry _build_registryctl _build_trivy_adapter _build_redis _compile_and_build_exporter
236+
ifeq ($(BUILD_INSTALLER), true)
237+
buildcompt: _build_prepare _build_db _build_portal _build_core _build_jobservice _build_log _build_nginx _build_registry _build_registryctl _build_trivy_adapter _build_redis _compile_and_build_exporter
238+
else
239+
buildcompt: _build_db _build_portal _build_core _build_jobservice _build_nginx _build_registry _build_registryctl _build_trivy_adapter _build_redis _compile_and_build_exporter
240+
endif
241+
242+
build: buildcompt
237243
@if [ -n "$(REGISTRYUSER)" ] && [ -n "$(REGISTRYPASSWORD)" ] ; then \
238244
docker logout ; \
239245
fi
246+
240247
cleanimage:
241248
@echo "cleaning image for photon..."
242249
- $(DOCKERRMIMAGE) -f $(DOCKERIMAGENAME_PORTAL):$(VERSIONTAG)

0 commit comments

Comments
 (0)