add dockernetwork parameter for build process #22138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinerYang
added
the
release-note/ignore-for-release
MinerYang
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22138 +/- ##
===========================================
+ Coverage 45.36% 65.87% +20.50%
===========================================
Files 244 1072 +828
Lines 13333 115713 +102380
Branches 2719 2925 +206
===========================================
+ Hits 6049 76221 +70172
- Misses 6983 35264 +28281
- Partials 301 4228 +3927
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
MinerYang
force-pushed
the
add_build_network_para
branch
2 times, most recently
from
ad740d0 to
30928fa
Compare
Signed-off-by: my036811 <[email protected]>
MinerYang
force-pushed
the
add_build_network_para
branch
from
30928fa to
da17772
Compare
OrlinVasilev
added
release-note/update
AYDEV-FR
pushed a commit
to AYDEV-FR/harbor
that referenced
this pull request
Jul 4, 2025
add dockernetwork parameter for makefile Signed-off-by: my036811 <[email protected]> Signed-off-by: AYDEV-FR <[email protected]>
5 tasks
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
add dockernetwork parameter for makefile Signed-off-by: my036811 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
To better adopt different container build network environment, we would like to add a docker build network parameter in Makefile that developer would specified during build process.
Issue being fixed
Fixes #22137