Skip to content

Commit 0a3c06d

Browse files
authored
add dockernetwork parameter for build process (#22138)
add dockernetwork parameter for makefile Signed-off-by: my036811 <[email protected]>
1 parent 6be2971 commit 0a3c06d

4 files changed

Lines changed: 9 additions & 5 deletions

File tree

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ endef
130130
# docker parameters
131131
DOCKERCMD=$(shell which docker)
132132
DOCKERBUILD=$(DOCKERCMD) build
133+
DOCKERNETWORK=default
133134
DOCKERRMIMAGE=$(DOCKERCMD) rmi
134135
DOCKERPULL=$(DOCKERCMD) pull
135136
DOCKERIMAGES=$(DOCKERCMD) images
@@ -395,6 +396,7 @@ build:
395396
-e REGISTRYVERSION=$(REGISTRYVERSION) -e REGISTRY_SRC_TAG=$(REGISTRY_SRC_TAG) -e DISTRIBUTION_SRC=$(DISTRIBUTION_SRC)\
396397
-e TRIVYVERSION=$(TRIVYVERSION) -e TRIVYADAPTERVERSION=$(TRIVYADAPTERVERSION) \
397398
-e VERSIONTAG=$(VERSIONTAG) \
399+
-e DOCKERNETWORK=$(DOCKERNETWORK) \
398400
-e BUILDREG=$(BUILDREG) -e BUILDTRIVYADP=$(BUILDTRIVYADP) \
399401
-e NPM_REGISTRY=$(NPM_REGISTRY) -e BASEIMAGETAG=$(BASEIMAGETAG) -e IMAGENAMESPACE=$(IMAGENAMESPACE) -e BASEIMAGENAMESPACE=$(BASEIMAGENAMESPACE) \
400402
-e REGISTRYURL=$(REGISTRYURL) \

make/photon/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ TIMESTAMP=$(shell date +"%Y%m%d")
1818

1919
# docker parameters
2020
DOCKERCMD=$(shell which docker)
21-
DOCKERBUILD=$(DOCKERCMD) build --no-cache
21+
DOCKERBUILD=$(DOCKERCMD) build --no-cache --network=$(DOCKERNETWORK)
2222
DOCKERBUILD_WITH_PULL_PARA=$(DOCKERBUILD) --pull=$(PULL_BASE_FROM_DOCKERHUB)
2323
DOCKERRMIMAGE=$(DOCKERCMD) rmi
2424
DOCKERIMAGES=$(DOCKERCMD) images
@@ -154,7 +154,7 @@ _build_trivy_adapter:
154154
$(call _extract_archive, $(TRIVY_ADAPTER_DOWNLOAD_URL), $(DOCKERFILEPATH_TRIVY_ADAPTER)/binary/) ; \
155155
else \
156156
echo "Building Trivy adapter $(TRIVYADAPTERVERSION) from sources..." ; \
157-
cd $(DOCKERFILEPATH_TRIVY_ADAPTER) && $(DOCKERFILEPATH_TRIVY_ADAPTER)/builder.sh $(TRIVYADAPTERVERSION) $(GOBUILDIMAGE) && cd - ; \
157+
cd $(DOCKERFILEPATH_TRIVY_ADAPTER) && $(DOCKERFILEPATH_TRIVY_ADAPTER)/builder.sh $(TRIVYADAPTERVERSION) $(GOBUILDIMAGE) $(DOCKERNETWORK) && cd - ; \
158158
fi ; \
159159
echo "Building Trivy adapter container for photon..." ; \
160160
$(DOCKERBUILD_WITH_PULL_PARA) --build-arg harbor_base_image_version=$(BASEIMAGETAG) \
@@ -178,7 +178,7 @@ _build_registry:
178178
rm -rf $(DOCKERFILEPATH_REG)/binary && mkdir -p $(DOCKERFILEPATH_REG)/binary && \
179179
$(call _get_binary, $(REGISTRYURL), $(DOCKERFILEPATH_REG)/binary/registry); \
180180
else \
181-
cd $(DOCKERFILEPATH_REG) && $(DOCKERFILEPATH_REG)/builder $(REGISTRY_SRC_TAG) $(DISTRIBUTION_SRC) $(GOBUILDIMAGE) && cd - ; \
181+
cd $(DOCKERFILEPATH_REG) && $(DOCKERFILEPATH_REG)/builder $(REGISTRY_SRC_TAG) $(DISTRIBUTION_SRC) $(GOBUILDIMAGE) $(DOCKERNETWORK) && cd - ; \
182182
fi
183183
@echo "building registry container for photon..."
184184
@chmod 655 $(DOCKERFILEPATH_REG)/binary/registry && $(DOCKERBUILD_WITH_PULL_PARA) --build-arg harbor_base_image_version=$(BASEIMAGETAG) --build-arg harbor_base_namespace=$(BASEIMAGENAMESPACE) -f $(DOCKERFILEPATH_REG)/$(DOCKERFILENAME_REG) -t $(DOCKERIMAGENAME_REG):$(VERSIONTAG) .

make/photon/registry/builder

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ fi
1515
VERSION="$1"
1616
DISTRIBUTION_SRC="$2"
1717
GOBUILDIMAGE="$3"
18+
DOCKERNETWORK="$4"
1819

1920
set -e
2021

@@ -33,7 +34,7 @@ cd $cur
3334

3435
echo 'build the registry binary ...'
3536
cp Dockerfile.binary $TEMP
36-
docker build --build-arg golang_image=$GOBUILDIMAGE -f $TEMP/Dockerfile.binary -t registry-golang $TEMP
37+
docker build --network=$DOCKERNETWORK --build-arg golang_image=$GOBUILDIMAGE -f $TEMP/Dockerfile.binary -t registry-golang $TEMP
3738

3839
echo 'copy the registry binary to local...'
3940
ID=$(docker create registry-golang)

make/photon/trivy-adapter/builder.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ fi
99

1010
VERSION="$1"
1111
GOBUILDIMAGE="$2"
12+
DOCKERNETWORK="$3"
1213

1314
set -e
1415

@@ -22,7 +23,7 @@ cd $TEMP; git checkout $VERSION; cd -
2223

2324
echo "Building Trivy adapter binary ..."
2425
cp Dockerfile.binary $TEMP
25-
docker build --build-arg golang_image=$GOBUILDIMAGE -f $TEMP/Dockerfile.binary -t trivy-adapter-golang $TEMP
26+
docker build --network=$DOCKERNETWORK --build-arg golang_image=$GOBUILDIMAGE -f $TEMP/Dockerfile.binary -t trivy-adapter-golang $TEMP
2627

2728
echo "Copying Trivy adapter binary from the container to the local directory..."
2829
ID=$(docker create trivy-adapter-golang)

0 commit comments

Comments
 (0)