Skip to content

Fix bug with marshalling experiments #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2024
Merged

Fix bug with marshalling experiments #259

merged 3 commits into from
Jun 17, 2024

Conversation

@ridiculous
Copy link
Contributor

@ridiculous ridiculous commented Mar 26, 2024 •
edited
Loading

Allows this to work:

Marshal.load(Marshal.dump(Scientist::Default.new("foo")))
#=> ArgumentError: wrong number of arguments (given 1, expected 0)
#=> from /Users/ryan.buckley/.rvm/gems/ruby-2.7.8@envoy-web/gems/scientist-1.6.3/lib/scientist/experiment.rb:334:in `marshal_load'

@zerowidth zerowidth merged commit 987f8be into github:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerowidth zerowidth zerowidth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ridiculous @zerowidth