Skip to content

Fix bug with marshalling experiments #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Fix bug with marshalling experiments #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c297ab
Fix bug with marshalling experiments
ridiculous Mar 26, 2024
b98d3f8
Add test for marshal load
ridiculous Mar 26, 2024
2c4c6e9
Fix syntax error
ridiculous Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/scientist/experiment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ def marshal_dump
[@name, @result, @raise_on_mismatches]
end

def marshal_load
def marshal_load(array)
@name, @result, @raise_on_mismatches = array
end
end
4 changes: 4 additions & 0 deletions test/scientist/experiment_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,10 @@ def @ex.raised(op, exception)
assert_kind_of(String, Marshal.dump(mismatch))
end

it "can be marshal loaded" do
assert_kind_of(Fake, Marshal.load(Marshal.dump(@ex)))
end

describe "#raise_on_mismatches?" do
it "raises when there is a mismatch if the experiment instance's raise on mismatches is enabled" do
Fake.raise_on_mismatches = false
Expand Down