-
Notifications
You must be signed in to change notification settings - Fork 1.5k
1140, Replace QTip2 with Hint.css #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1140, Replace QTip2 with Hint.css #1141
Conversation
|
Thanks @chahmedejaz! I tried it out and have a few comments. First, something changed with the /appendix page; the green/blue/red circles are now flush to the left of their table cells, rather than centered: Second, in a very narrow browser window, the tooltips get cut off; this is not a huge deal as it was the case for the existing site until very recently #1133 but it'd be nice not to regress: Third and least importantly, light text on darker color background (taken from the current heading?) strikes me as harder to read than darker color text on light color background (like the current message). Added: I might be wrong, guess it's a matter of taste. |
|
Thank you @mlinksva for the review. Let me address the comments and get back to you 😄 |
|
Hey @mlinksva - I've addressed your comments. Please review the fixes. Results: The appendix page is as per the original site now: Please let me know if I'm missing anything. Thanks. |
|
|
Hey @mlinksva - I've addressed your comments, please review. Thanks. |
|
I noticed that the tooltip arrow colors were lost due to the new color class names. Updated the arrow color for the new classes here |
mlinksva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, all looks like it's working. One final comment: think we could avoid vendoring hint.css source
mlinksva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 @chahmedejaz, well done and thanks









Hi there!

This PR replaces the QTips2 package functionality with the Hint.css as per issue #1140.
Here are the results after the replacement:
Here's the point to be noted:

Previously we were showing the formatted error message for the repository URL input field error:
However, the hint.css package doesn't support the html tags in the tooltip body. Due to this limitation, we are now showing the error message in plain text:
