Skip to content

Conversation

@chahmedejaz
Copy link
Contributor

@chahmedejaz chahmedejaz commented Aug 27, 2023

Hi there!
This PR replaces the QTips2 package functionality with the Hint.css as per issue #1140.
Here are the results after the replacement:
image

image

Here's the point to be noted:
Previously we were showing the formatted error message for the repository URL input field error:
image

However, the hint.css package doesn't support the html tags in the tooltip body. Due to this limitation, we are now showing the error message in plain text:
image

@chahmedejaz chahmedejaz marked this pull request as ready for review August 27, 2023 18:46
@chahmedejaz chahmedejaz marked this pull request as draft August 27, 2023 18:53
@chahmedejaz chahmedejaz marked this pull request as ready for review August 28, 2023 07:29
@mlinksva
Copy link
Contributor

mlinksva commented Aug 29, 2023

Thanks @chahmedejaz! I tried it out and have a few comments.

First, something changed with the /appendix page; the green/blue/red circles are now flush to the left of their table cells, rather than centered:

image

Second, in a very narrow browser window, the tooltips get cut off; this is not a huge deal as it was the case for the existing site until very recently #1133 but it'd be nice not to regress:

Screenshot 2023-08-28 at 6 29 47 PM

Third and least importantly, light text on darker color background (taken from the current heading?) strikes me as harder to read than darker color text on light color background (like the current message). Added: I might be wrong, guess it's a matter of taste.

@chahmedejaz
Copy link
Contributor Author

chahmedejaz commented Aug 29, 2023

Thank you @mlinksva for the review. Let me address the comments and get back to you 😄

@chahmedejaz
Copy link
Contributor Author

chahmedejaz commented Aug 30, 2023

Hey @mlinksva - I've addressed your comments. Please review the fixes.

Results:
Now the tooltip is responsive:
image

Tooltip colors:
image
image
image

The appendix page is as per the original site now:
image

Please let me know if I'm missing anything. Thanks.

@mlinksva
Copy link
Contributor

The screenshots look good, but when I run it, the tooltips have odd shadow or doubled text:

Screenshot 2023-08-30 at 5 19 41 PM

This is on a Mac FWIW, but I get the same on both Firefox and Chrome.

Any idea what could be causing that?

@chahmedejaz
Copy link
Contributor Author

chahmedejaz commented Aug 31, 2023

@mlinksva -

  • Actually this effect is from the hint.css
  • It is putting the shadow on the tool-tip body text and causing the doubled-text effect
  • I've overridden this shadow to none for our use and hopefully it will do the fix
  • It's putting the shadow at my end as well but apparently it's more prominent at your end 😅

Result:
image

@chahmedejaz
Copy link
Contributor Author

chahmedejaz commented Aug 31, 2023

Hey @mlinksva - I've addressed your comments, please review. Thanks.

@chahmedejaz
Copy link
Contributor Author

chahmedejaz commented Aug 31, 2023

I noticed that the tooltip arrow colors were lost due to the new color class names. Updated the arrow color for the new classes here

Copy link
Contributor

@mlinksva mlinksva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, all looks like it's working. One final comment: think we could avoid vendoring hint.css source

Copy link
Contributor

@mlinksva mlinksva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 @chahmedejaz, well done and thanks

@mlinksva mlinksva merged commit 2f7a122 into github:gh-pages Aug 31, 2023
@mlinksva mlinksva mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants