Fix qtip viewport overflow. #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qtips under the permissons was overflowing left of the screen and only half of the text was readable. To activate position.adjust.method plugin, I added the viewport option. Also changed default adjust method to shift instead of flip.
Contributor
Author
|
Here are the screen shots of before and after:
|
mlinksva
reviewed
Aug 11, 2023
assets/vendor/qtip2/jquery.qtip.js
Outdated
| scroll: TRUE, | ||
| resize: TRUE, | ||
| method: 'flipinvert flipinvert' | ||
| method: 'shift shift' |
Contributor
There was a problem hiding this comment.
Is changing the defaults in the vendored code necessary? Why not add to app.coffee as done with viewport?
Contributor
Author
There was a problem hiding this comment.
I reverted my last commit and did the changes only on app.coffe
This reverts commit 44b4904.
I reverted my last commit on vendor code and did the changes on app.coffe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qtips under the permissons was overflowing left of the screen and only half of the text was readable. To activate position.adjust.method plugin, I added the viewport option. Also changed default adjust method to shift instead of flip.