Skip to content

Use published sign.exe CLI and 3rd part certificate extractor tools #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjcheetham merged 3 commits into from
Jul 2, 2024
Merged

Use published sign.exe CLI and 3rd part certificate extractor tools #1647

mjcheetham merged 3 commits into from
Jul 2, 2024

Conversation

@mjcheetham
Copy link
Contributor

@mjcheetham mjcheetham commented Jul 2, 2024

Use a 3rd party tool to extract the NuGet signing certificate for upload rather than relying on an option added to the sign.exe tool in a private fork. At the same time let's use the dotnet tool install command to acquire the code signing tool, rather than rely on our Azure blob store.

Also let's drop the -d and -u options from the sign.exe CLI; they are no longer required (source).

mjcheetham added 3 commits July 2, 2024 13:57
@mjcheetham
release: use 3rd party tool to extract nuget cert
f8c2c34 
Use a 3rd party tool to extract the NuGet signing certificate for upload
rather than relying on an option added to the sign.exe tool in a private
fork.
@mjcheetham
release: use dotnet tool install to get sign CLI
5c6d808 
Use the `dotnet tool install` command to acquire the code signing tool,
rather than rely on our Azure blob store.
@mjcheetham
release: drop no longer required sign.exe options
ddba796 
Drop the `-d` and `-u` options from the sign.exe CLI; they are no longer
required.
@mjcheetham mjcheetham requested review from dscho and vdye July 2, 2024 21:00
dscho
dscho approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mjcheetham mjcheetham merged commit 07e579d into git-ecosystem:main Jul 2, 2024
@mjcheetham mjcheetham deleted the upstream-signing branch July 2, 2024 21:05
@mjcheetham mjcheetham mentioned this pull request Jul 2, 2024
Merged
mjcheetham added a commit that referenced this pull request Jul 2, 2024
@mjcheetham
Release 2.5.1 (#1648)
4b0808b 
**Changes:**

- Update MSAL and Avalonia to latest versions (#1640).
- Changes to release workflow to publish NuGet signing certificate
(#1594, #1644, #1647).
- Updates to Managed Identity and Service Principal docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscho dscho dscho approved these changes

@vdye vdye Awaiting requested review from vdye

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjcheetham @dscho