release: capture nuget signing cert #1594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet requires that signed packages have a matching registered signing certificate [1]. Update release workflow to capture this certificate from the Sign CLI tool and upload it as a release artifact. 1: https://learn.microsoft.com/en-us/nuget/create-packages/sign-a-package#register-the-certificate-on-nugetorg
mjcheetham
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet requires that signed packages have a matching registered signing certificate. Update release workflow to capture this certificate from the Sign CLI tool and upload it as a release artifact. Note that this means we will need to manually update this certificate to the
git-credential-managerorganization in nuget.org prior to publishing the .NET tool version for each release.Tested the end-to-end flow in my fork which resulted in publication of this package to the NuGet QA Gallery.