Skip to content

Fixing Windows --no-mmap model loading#18204

Merged
ggerganov merged 1 commit intoggml-org:masterfrom
JTischbein:model_load_windows_fix
Dec 19, 2025
Merged

Fixing Windows --no-mmap model loading#18204
ggerganov merged 1 commit intoggml-org:masterfrom
JTischbein:model_load_windows_fix

Conversation

@JTischbein
Copy link
Contributor

In the llama_model_loader.cpp the typedef off_t was used in a code path which is also used on Windows (PR #18012). On Windows this type is defined as signed long, which is too small for file offsets. Changing in this PR off_t to size_t.

@ggerganov ggerganov merged commit f99ef53 into ggml-org:master Dec 19, 2025
67 of 68 checks passed
@taronaeo taronaeo linked an issue Dec 19, 2025 that may be closed by this pull request
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: MMAP off causes load model to fail

2 participants