Skip to content

Fixing Windows --no-mmap model loading - #18204

Merged
ggerganov merged 1 commit into
ggml-org:masterfrom
JTischbein:model_load_windows_fix
Dec 19, 2025
Merged

Fixing Windows --no-mmap model loading#18204
ggerganov merged 1 commit into
ggml-org:masterfrom
JTischbein:model_load_windows_fix

Conversation

@JTischbein

Copy link
Copy Markdown
Contributor

In the llama_model_loader.cpp the typedef off_t was used in a code path which is also used on Windows (PR #18012). On Windows this type is defined as signed long, which is too small for file offsets. Changing in this PR off_t to size_t.

@ggerganov
ggerganov merged commit f99ef53 into ggml-org:master Dec 19, 2025
67 of 68 checks passed
@taronaeo taronaeo linked an issue Dec 19, 2025 that may be closed by this pull request
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
MrLordCat referenced this pull request in MrLordCat/llama.cpp-with-GUI Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: MMAP off causes load model to fail

2 participants