UPSTREAM PR #18204: Fixing Windows --no-mmap model loading#625
Closed
UPSTREAM PR #18204: Fixing Windows --no-mmap model loading#625
Conversation
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Error
loci-dev
force-pushed
the
main
branch
19 times, most recently
from
26a6f0f to
cf53bc9
Compare
DajanaV
deleted the
upstream-PR18204-branch_JTischbein-model_load_windows_fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18204
In the llama_model_loader.cpp the typedef
off_twas used in a code path which is also used on Windows (PR #18012). On Windows this type is defined assigned long, which is too small for file offsets. Changing in this PRoff_ttosize_t.