compare-commits.sh: support both llama-bench and test-backend-ops#14392
compare-commits.sh: support both llama-bench and test-backend-ops#14392yeahdongcn merged 6 commits intoggml-org:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for comparing performance results from both llama-bench and test-backend-ops by introducing tool-specific database schemas, CLI argument parsing, and formatting functions. Key changes include:
- Refactoring database field and key property definitions to support both tools.
- Updating table queries and input file handling based on a new --tool argument.
- Enhancing the CLI script (compare-commits.sh) to allow selection of the tool and additional arguments.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/compare-llama-bench.py | Adjusts SQLite table creation, queries, and result formatting for dual tool support. |
| scripts/compare-commits.sh | Updates argument parsing and build/run logic to handle multiple tools. |
|
Hi @JohannesGaessler @slaren @ggerganov I’ve merged #14368 into master. Could you please continue reviewing this one when you have a moment? Thanks! |
5c1951b to
b5ea15f
Compare
5e8f738 to
7736d64
Compare
|
Hi @JohannesGaessler Just wanted to check if there are any other concerns I should address. Thanks! |
a7940f7 to
3a19ed3
Compare
JohannesGaessler
left a comment
There was a problem hiding this comment.
Sorry for the delay, I forgot about this PR.
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
3a19ed3 to
9df06fc
Compare
Everything has been updated accordingly. Thanks again for your review. |
…4392) * compare-commits.sh: support both llama-bench and test-backend-ops Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com> * Speed up the build by specifying -j 12 Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com> * Remove build_number from test-backend-ops db Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com> * Apply suggestion from @JohannesGaessler Co-authored-by: Johannes Gäßler <johannesg@5d6.de> * Refine tool selection logic Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com> * Address review comments Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com> --------- Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com> Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com> Co-authored-by: Johannes Gäßler <johannesg@5d6.de>
Make sure to read the contributing guidelines before submitting a PR
This is a follow-up to #14368, adding support for comparing
test-backend-opsperformance results between two commits.Testing Done
Generated Tables
Generated Plot
Full Logs
test-backend-ops:
llama-bench: