Add script to test op perf and compare#14354
Add script to test op perf and compare#14354yeahdongcn wants to merge 3 commits intoggml-org:masterfrom
Conversation
|
I actually wasn't thinking to push the script as I think it still had some flaws but I don't mind if you do, especially with the changes you did. |
No problem! I modified the original script, which is now useful for quickly diffing changes in specific operations. |
|
@daniandtheweb I’m afraid I can’t see your public email address — could you share it somewhere or post it here? |
|
I put the e-mail private to avoid spam some time ago but I guess it's better to keep it public for contributions. I've changed the settings of my github account, I think now you should be able to see my email. |
JohannesGaessler
left a comment
There was a problem hiding this comment.
It would be a much better solution to format the output of test-backend-ops as e.g. SQL and to adapt compare-llama-bench.py so that the same code can be used for both llama-bench and test-backend-ops. However, as of right now we do not have any tools at all to compare the performance of test-backend-ops so I would consider this PR to be an improvement over master and would be willing to merge it.
|
By the way, these scripts are only going to work correctly for ops where the performance is reported as FLOPS, not for ops where it's reported as GB/s. |
Co-authored-by: Daniele <daniele.dilotorres@gmail.com> Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
48909db to
64f137e
Compare
That’s a great idea. I’ll look into whether adding a
Thanks for pointing that out! I missed it. |
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
b04e5c5 to
6c62e6b
Compare
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
|
@JohannesGaessler I’ve drafted a new PR #14368 to add support for specifying the output format in |
Make sure to read the contributing guidelines before submitting a PR
This PR adds performance comparison support for
test-backend-ops perf, similar to the existingcompare-commits.shandcompare-llama-bench.pyscripts.The original Python script was provided by @daniandtheweb — credit goes to him!
Testing Done
The following tests were performed on an MTT S80.
GFLOPS
Generated report:
GB/s